Survive /buffer clear
#578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zopieux
approved these changes
Feb 23, 2024
app/src/main/java/com/ubergeek42/WeechatAndroid/adapters/ChatLinesAdapter.kt
Outdated
Show resolved
Hide resolved
oakkitten
force-pushed
the
handle-buffer-cleared
branch
2 times, most recently
from
728fcc6 to
8a4c9d6
Compare
mhoran
approved these changes
Feb 23, 2024
oakkitten
force-pushed
the
handle-buffer-cleared
branch
from
8a4c9d6 to
83c5039
Compare
Fixes some of #577
When buffer is cleared using `/buffer clear` and more lines are added, line pointers may be reused. Before, if the app was disconnected during these events, after reconnection it was possible for the lines to appear out of order. This happened because normally we calculate diff using pointers only, and if we had an older line with the same pointer as the newer one, the adapter would reuse the old view holder, which might've been displaying the wrong line. This fixes the issue by also looking at line contents while diffing. This solution is not ideal: * While we can reliably tell whether the contents of two lines are the same, during the diffing we also want to know whether two lines represent the same thing, even if the contents have changed. As the pointer can be reused, sometimes `areItemsTheSame` will return a false positive. However, with this change the negative effect of this shouldn't go beyond wrong animation being applied. * Read marker may appear in a wrong place. We save the pointer to the last read line locally, and if the pointer is reused, there's no way for us to tell that the line is wrong. Fixes #577
oakkitten
force-pushed
the
handle-buffer-cleared
branch
from
83c5039 to
18ae946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits & their messages. I hope this doesn't break things, will require a bit of hands-on testing.