generated from ubiquity/ts-template
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use issue.node_id for permit nonces #108
Merged
rndquu
merged 7 commits into
ubiquity-os-marketplace:development
from
rndquu:fix/nonce-generation
Sep 10, 2024
Merged
fix: use issue.node_id for permit nonces #108
rndquu
merged 7 commits into
ubiquity-os-marketplace:development
from
rndquu:fix/nonce-generation
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Sep 9, 2024
0x4007
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's always use latest. Otherwise looks good to me.
gentlementlegen
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ubiquity-os/permit-generation#46
QA (
development
branch, old buggy behavior):rndquu-org/my-repo-1#1 (comment):
nonce=78893650957373058525222459826056873078870981337600027323707876018366845390587
rndquu-org/my-repo-2#1 (comment):
nonce=78893650957373058525222459826056873078870981337600027323707876018366845390587
QA (
fix/nonce-generation
branch):rndquu-org/my-repo-1#1 (comment):
nonce=47174999346132534354494673705511461942918468951327270802916300108996236752932
rndquu-org/my-repo-2#1 (comment):
nonce=83029153680898263555035957871388564685254995512260384748899620589901226451761
In the 1st case (QA for
development
branch) nonces are the same because issue number is used for nonce generation (notissue.id
orissue.node_id
). Hence 2 issues with the same issue number across 2 different repositories have equal nonces.In the 2nd case (QA for
fix/nonce-generation
branch) we useissue.node_id
for nonce generation which is different for any 2 repositories we take.Notes:
locations
table). When we're about to remove the deprecatedlocations
table then issue number related logic can be removed as well.issue.node_id
instead of issue number hence permit URLs changedExceeded timeout of 10000 ms for a test
)