Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Archived repositories and Mesages starting with @UbiquityOS #46

Conversation

Sadaf-A
Copy link

@Sadaf-A Sadaf-A commented Dec 23, 2024

Resolves #7

@Sadaf-A
Copy link
Author

Sadaf-A commented Dec 29, 2024

@0x4007 could I please get a review on this?

@Sadaf-A
Copy link
Author

Sadaf-A commented Dec 30, 2024

@rndquu could you please review this PR?
Thank You

@rndquu
Copy link
Member

rndquu commented Dec 31, 2024

@rndquu could you please review this PR? Thank You

Could you provide QA links of how it works for @UbiquityOS, archived and none-archived repositories?

@Sadaf-A
Copy link
Author

Sadaf-A commented Dec 31, 2024

@rndquu could you please review this PR? Thank You

Could you provide QA links of how it works for @UbiquityOS, archived and none-archived repositories?

Hey, is there a guide available for how to QA?

@rndquu
Copy link
Member

rndquu commented Dec 31, 2024

@rndquu could you please review this PR? Thank You

Could you provide QA links of how it works for @UbiquityOS, archived and none-archived repositories?

Hey, is there a guide available for how to QA?

Just post URL links in the comments to prove that the feature works and nothing is broken

Copy link

The name of this repository is @ubiquity-os/command-ask. You can find it under the ubiquity-os-marketplace organization on GitHub.

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

@rndquu could you please review this PR? Thank You

Could you provide QA links of how it works for @UbiquityOS, archived and none-archived repositories?

Hey, is there a guide available for how to QA?

Just post URL links in the comments to prove that the feature works and nothing is broken

Hey, where should I post the comment?

@rndquu
Copy link
Member

rndquu commented Jan 1, 2025

@rndquu could you please review this PR? Thank You

Could you provide QA links of how it works for @UbiquityOS, archived and none-archived repositories?

Hey, is there a guide available for how to QA?

Just post URL links in the comments to prove that the feature works and nothing is broken

Hey, where should I post the comment?

In the PR description

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

@rndquu could you please review this PR? Thank You

Could you provide QA links of how it works for @UbiquityOS, archived and none-archived repositories?

Hey, is there a guide available for how to QA?

Just post URL links in the comments to prove that the feature works and nothing is broken

Hey, where should I post the comment?

In the PR description

So this PR is using the same code that I pushed?

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

@UbiquityOS testing

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

/ask testing

Copy link

Hello! It looks like you're testing the UbiquityOS bot. How can I assist you with your GitHub repository today?

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

/ask what is this repository's name?

Copy link

The repository's name is ubiquity-os-marketplace/command-ask.

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

@UbiquityOS testing

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 1, 2025

@rndquu how do I check for archived repo?

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 2, 2025

/ask how do I do QA for this repo?

Copy link

To perform Quality Assurance (QA) for this repository, please follow the steps outlined below to ensure that your contributions meet our project's standards and function as intended:

  1. Run Automated Tests with Jest:

    • Install Dependencies: Ensure all project dependencies are installed by running:
      yarn install
    • Execute Tests: Run the test suite to verify that all functionalities work correctly:
      yarn test
    • Review Test Results: Ensure that all tests pass successfully. If any tests fail, review the error messages, address the issues in your code, and re-run the tests until they pass.
  2. Check Code Quality with ESLint and Prettier:

    • Lint the Code: Use ESLint to identify and fix linting issues:
      yarn lint
    • Format the Code: Ensure consistent code formatting by running Prettier:
      yarn format
    • Automate Checks: Git hooks managed by Husky and lint-staged will automatically enforce linting and formatting on your commits. Ensure that these hooks are functioning correctly by making a commit and verifying that linting/formatting is applied.
  3. Deploy for Manual Testing with Wrangler:

    • Build the Project: Prepare your project for deployment:
      yarn build
    • Deploy to Cloudflare Workers: Use Wrangler to deploy your changes to a staging environment for manual verification:
      wrangler deploy
    • Verify Deployment: Access the deployed URL to manually test the functionalities you've implemented or modified. Ensure that everything works as expected in the live environment.
  4. Provide QA Evidence in Pull Request:

    • Post QA Links: After completing both automated and manual testing, provide evidence that your changes are functioning correctly by posting relevant URL links in the pull request (PR) description. These links should demonstrate that the feature works and that no existing functionalities are broken.
      • Example:
        ### QA Links
        - [Live Deployment](https://your-deployed-app-url.com)
        - [Test Coverage Report](https://your-reports-url.com/coverage)
    • Describe Testing Performed: Briefly outline the tests you've conducted, including any manual testing scenarios, to give reviewers a clear understanding of your QA process.
  5. Ensure Comprehensive Coverage:

    • Unit Tests: Verify that your changes are covered by unit tests. If necessary, add new tests to cover additional cases or functionalities you've introduced.
    • Documentation: Update or add documentation as needed to reflect any new features or changes. This ensures that other contributors and users can understand and utilize your contributions effectively.
  6. Final Review:

    • Code Review: Before requesting a review, double-check that your code adheres to the project's coding standards and that all tests pass.
    • Request Feedback: Tag relevant team members or reviewers to inspect your PR and provide feedback based on the QA evidence you've supplied.

By following these steps, you help maintain the integrity and quality of the project, ensuring that all contributions are reliable and well-documented. If you encounter any issues or have questions during the QA process, feel free to reach out for assistance.


Quick Reference Commands:

  • Install Dependencies: yarn install
  • Run Tests: yarn test
  • Lint Code: yarn lint
  • Format Code: yarn format
  • Build Project: yarn build
  • Deploy with Wrangler: wrangler deploy

Resources:

By ensuring thorough QA, you contribute to a robust and reliable codebase that benefits the entire UbiquityOS community.

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 3, 2025

@rndquu hey could you please confirm if this is the right way to do QA?

src/handlers/ask-llm.ts Outdated Show resolved Hide resolved
@rndquu
Copy link
Member

rndquu commented Jan 4, 2025

@rndquu hey could you please confirm if this is the right way to do QA?

Post URLs from your own repository which show that the feature works as expected for:

  • @UbiquityOS,
  • archived repositories
  • none-archived repositories

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 4, 2025

@rndquu hey could you please confirm if this is the right way to do QA?

Post URLs from your own repository which show that the feature works as expected for:

  • @UbiquityOS,
  • archived repositories
  • none-archived repositories

I don't understand should I comment in my fork after creating an issue like this or something else?
Could you please elaborate a little more on how to set things up as this is my first time contributing to this repo.
Thank You

@rndquu
Copy link
Member

rndquu commented Jan 4, 2025

@rndquu hey could you please confirm if this is the right way to do QA?

Post URLs from your own repository which show that the feature works as expected for:

  • @UbiquityOS,
  • archived repositories
  • none-archived repositories

I don't understand should I comment in my fork after creating an issue like this or something else? Could you please elaborate a little more on how to set things up as this is my first time contributing to this repo. Thank You

Create a github issue in your fork, check how it works in your fork, post URLs to relevant issue which shows how the feature works in comments in the current github issue.

@Sadaf-A
Copy link
Author

Sadaf-A commented Jan 4, 2025

@rndquu hey could you please confirm if this is the right way to do QA?

Post URLs from your own repository which show that the feature works as expected for:

  • @UbiquityOS,
  • archived repositories
  • none-archived repositories

I don't understand should I comment in my fork after creating an issue like this or something else? Could you please elaborate a little more on how to set things up as this is my first time contributing to this repo. Thank You

Create a github issue in your fork, check how it works in your fork, post URLs to relevant issue which shows how the feature works in comments in the current github issue.

Thanks. Am I missing something cause there are no replies.

Copy link

@Sadaf-A, this task has been idle for a while. Please provide an update.

Copy link

@Sadaf-A, this task has been idle for a while. Please provide an update.

@ubiquity-os-beta ubiquity-os-beta bot closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excluding Archived Repositories
3 participants