Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add rolesWithReviewAuth to config #37

Merged
merged 8 commits into from
Sep 23, 2024
Merged

fix: add rolesWithReviewAuth to config #37

merged 8 commits into from
Sep 23, 2024

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Sep 7, 2024

Resolves #36

@gentlementlegen
Copy link
Member

@Keyrxng Can this be reviewed?

@Keyrxng
Copy link
Member Author

Keyrxng commented Sep 13, 2024

@Keyrxng Can this be reviewed?

Yeah it is sorry I forgot to request review. I also didn't provide QA you want me to get some first?

@Keyrxng
Copy link
Member Author

Keyrxng commented Sep 16, 2024

@gentlementlegen

ubq-testing#20

I left a comment re: my role within my own test org showing as CONTRIBUTOR from PR reviews from my main but the weird thing is the comment that I left on the issue (not the review) has my role displayed as member lmao. IDK What is causing the mismatch, I tried to debug but I can't find the cause.

It's not a problem for our prod org or a problem with this PR.

@gentlementlegen
Copy link
Member

It is quite strange. You are the owner of the organization correct?
Please fix the conflicts so I can review.

@Keyrxng
Copy link
Member Author

Keyrxng commented Sep 19, 2024

You are the owner of the organization correct?

I'm both an OWNER and naturally an ADMIN too

image

gentlementlegen
gentlementlegen reviewed Sep 19, 2024
View reviewed changes
tests/main.test.ts Outdated Show resolved Hide resolved
gentlementlegen
gentlementlegen reviewed Sep 19, 2024
View reviewed changes
tests/main.test.ts Outdated Show resolved Hide resolved
gentlementlegen
gentlementlegen approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gentlementlegen gentlementlegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine on my org. Can I bother you to rename the configuration to allowedReviewerRoles to match automated-merging?

@ubiquity-os ubiquity-os bot merged commit 05bacd5 into ubiquity-os-marketplace:development Sep 23, 2024
2 checks passed
@gentlementlegen gentlementlegen mentioned this pull request Sep 23, 2024
Open
@0x4007
Copy link
Member

0x4007 commented Sep 23, 2024

3 days is too soon for automated merge

@gentlementlegen
Copy link
Member

Currently set at "3.5 days" for collaborators, "7 days" for contributors, you can change these in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentlementlegen gentlementlegen gentlementlegen approved these changes

@0x4007 0x4007 Awaiting requested review from 0x4007

@whilefoo whilefoo Awaiting requested review from whilefoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude contributor reviews in user checks
3 participants
@Keyrxng @gentlementlegen @0x4007