ENS Fix #287
Comments
|
/start |
Tips:
|
|
@hhio618, this task has been idle for a while. Please provide an update. |
|
Update: |
|
I don't know what this is but the deliverable is unacceptable {"JSONRPC":"2.0","RESULT":"0X","ID":"1"} |
|
My theory is that the resolver is crashing because my main ens name contains non utf8 characters. We need a more robust solution. |
|
@0x4007, I’ve successfully resolved your address. After looking into the issue, it appears that if you're hard-coding the address parameter in the lookupAddress function, you may need to clear your browser cache. This could help ensure that outdated cached data isn't interfering with the lookup process. |
|
Only clearing cache? Seems unexpected as it is not a recycled response. Before it resolved another ens. After merging your pull it resolves as a JSON object. |
I suspect the caching issue might be happening here: https://github.com/hhio618/pay.ubq.fi/blob/de6d3988e3215a8ecbe5addf6d6a17ff4c08bf9e/static/scripts/rewards/cirip/query-reverse-ens.ts#L17 According to the ethers.js library, if a name isn't found, it should return null. Here's the relevant section of the code: https://github.com/ethers-io/ethers.js/blob/5aba4963e3e8ddfc912747076f5b7fe7a743cfe2/src.ts/providers/abstract-provider.ts#L1197 Could you please run the following snippet on your local configuration to see if it's returning the same json response or not? import { ethers } from "ethers";
const provider = new ethers.providers.JsonRpcProvider("https://eth.api.onfinality.io/public");
provider
.lookupAddress("0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605")
.then((ens: string) => {
console.log(`ens is ${ens}`);
})
.catch((error: Error) => {
console.error("Error connecting to provider:", error);
}); |
|
No I'm at a conference not on computer but you can check mine |
|
I've created a video to showcase this in action. It's successfully resolving both your UTF-8 ENS name and my ASCII ENS names. Please feel free to take a look! ens-test.mp4 |
|
@hhio618, this task has been idle for a while. Please provide an update. |
|
@0x4007, could you kindly take a moment to watch the video above? Additionally, I haven't been able to replicate the issue—would you be able to provide any further details that might help? |
I was able to reproduce the issue with the following steps: Navigate to the claim page, which populates the browser storage with JSON data from this file: query-reverse-ens.ts. |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 100 |
| Issue | Comment | 6 | 14.105 |
| Review | Comment | 1 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Update: You can see that the name is now being resolved correct… | 0.94content:
p:
symbols:
\b\w+\b:
count: 14
multiplier: 0.1
score: 1
img:
symbols:
\b\w+\b:
count: 1
multiplier: 0.1
score: 0
multiplier: 1
| 0.5 | 0.47 |
@0x4007, I’ve successfully resolved your address. After looking … | 2.83content:
p:
symbols:
\b\w+\b:
count: 51
multiplier: 0.1
score: 1
img:
symbols:
\b\w+\b:
count: 1
multiplier: 0.1
score: 0
multiplier: 1
| 0.8 | 2.264 |
I suspect the caching issue might be happening here: https://git… | 6.74content:
p:
symbols:
\b\w+\b:
count: 90
multiplier: 0.1
score: 1
pre:
symbols:
\b\w+\b:
count: 1
multiplier: 0.1
score: 0
code:
symbols:
\b\w+\b:
count: 37
multiplier: 0.1
score: 1
multiplier: 1
| 1 | 6.74 |
I've created a video to showcase this in action. It's successful… | 2.45content:
p:
symbols:
\b\w+\b:
count: 43
multiplier: 0.1
score: 1
multiplier: 1
| 0.4 | 0.98 |
@0x4007, could you kindly take a moment to watch the video above… | 2content:
p:
symbols:
\b\w+\b:
count: 34
multiplier: 0.1
score: 1
multiplier: 1
| 0.3 | 0.6 |
I was able to reproduce the issue with the following steps: Nav… | 3.39content:
p:
symbols:
\b\w+\b:
count: 56
multiplier: 0.1
score: 1
a:
symbols:
\b\w+\b:
count: 4
multiplier: 0.1
score: 1
multiplier: 1
| 0.9 | 3.051 |
Resolves #287 | 0content:
p:
symbols:
\b\w+\b:
count: 2
multiplier: 0
score: 1
multiplier: 0
| 0.1 | - |
[ 63.273 UUSD ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 58.84 |
| Issue | Comment | 4 | 3.553 |
| Review | Comment | 1 | 0.88 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
ENS is unreliable. There's two problems to fix: 1. Rate limitin… | 58.84content:
p:
symbols:
\b\w+\b:
count: 129
multiplier: 0.1
score: 1
ol:
symbols:
\b\w+\b:
count: 1
multiplier: 0.1
score: 0
li:
symbols:
\b\w+\b:
count: 2
multiplier: 0.1
score: 1
pre:
symbols:
\b\w+\b:
count: 1
multiplier: 0.1
score: 0
code:
symbols:
\b\w+\b:
count: 45
multiplier: 0.1
score: 5
img:
symbols:
\b\w+\b:
count: 1
multiplier: 0.1
score: 5
multiplier: 3
| 1 | 58.84 |
|
@0x4007 Apologies for the inconvenience, but it seems the payout cannot be claimed. |
rndquu and I are working on this. We have to bridge over some more to Gnosis Chain, and set up some markets, to set the infrastructure up |
|
@0x4007 Payout still not working, it would be great to have possibility to collect this bounty in other available tokens like WXDAI. |
ENS is unreliable. There's two problems to fix:
The text was updated successfully, but these errors were encountered: