-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ens lookup #297
fix: ens lookup #297
Conversation
Unused exports (1)
|
Delete the file |
@0x4007 Sure, still need the sub-graph query? |
I don't understand what you're talking about |
I meant this file: static/scripts/rewards/cirip/fetch-ens.ts, I believe this no longer needs to query the subgraph as we're reverse resolving the ens primary name! |
Your CI is failing because its unused. Delete the file. |
Interesting bug but check this comment for (the commit hash links) deploys with a permit when the CI passes. It doesn't work on Gnosis Chain, so you need to use an API which always checks mainnet, since thats the only name resolver we care about.
|
}), | ||
}); | ||
const web3Provider = new ethers.providers.JsonRpcProvider(mainnetRpcUrl); | ||
const ensName = await web3Provider.lookupAddress(address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keyrxng You can test the resolution by hard-coding the address parameter in your local deployment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it just grabs the first name you have from an array of all the ones you own. I own many, and it picks one consistently that is not my main.
I don't have the proper context to test against the spec but your right actually we both can test it.
@0x4007 what is your main? Which addresses should resolve to which ENS names?
@hhio618 You could provide a screenshot of the name being correctly resolved as QA. Each task should have some kind provided if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x4007 what is your main? Which addresses should resolve to which ENS names?
アレクサンダー.eth
Resolves #287
QA
You can see that the name is now being resolved correctly here: