Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ens lookup #297

Merged
merged 4 commits into from
Sep 14, 2024
Merged

fix: ens lookup #297

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3635c1
fix: ens lookup
hhio618 Sep 10, 2024
78aaac6
chore: remove the unused export
hhio618 Sep 11, 2024
ff36cce
fix: switch to mainnet rpc provider
hhio618 Sep 11, 2024
de6d398
chore: remove unused code
hhio618 Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions static/scripts/rewards/cirip/ens-lookup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import { ethers } from "ethers";
import abi from "../abis/cirip.json";
import { fetchEns } from "./fetch-ens";
import { queryReverseEns } from "./query-reverse-ens";

export const reverseEnsInterface = new ethers.utils.Interface(abi);

// addEventListener("fetch", event => {
// event.respondWith(handleRequest(event.request).catch(err => new Response(err.stack, { status: 500 })));
// });
Expand All @@ -24,9 +20,6 @@ export async function ensLookup(addr: string, networkId: number) {
// let response = "";
try {
reverseRecord = await queryReverseEns(address, networkId);
const responseParsed = JSON.parse(reverseRecord).result;
const _reverseRecord = ethers.utils.defaultAbiCoder.decode([ethers.utils.ParamType.from("string[]")], responseParsed);
reverseRecord = _reverseRecord[0][0];
} catch (e) {
console.error(e);
// throw "Error contacting ethereum node. \nCause: '" + e + "'. \nResponse: " + response;
Expand Down
24 changes: 6 additions & 18 deletions static/scripts/rewards/cirip/query-reverse-ens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { app } from "../app-state";
import { useRpcHandler } from "../web3/use-rpc-handler";
import { reverseEnsInterface } from "./ens-lookup";
import { ethers } from "ethers";

const mainnetRpcUrl = "https://eth.api.onfinality.io/public";
Keyrxng marked this conversation as resolved.
Show resolved Hide resolved

export async function queryReverseEns(address: string, networkId: number) {
// Try to get the ENS name from localStorage
Expand All @@ -17,28 +19,14 @@ export async function queryReverseEns(address: string, networkId: number) {
return cachedEnsName;
} else {
// If the ENS name is not in localStorage, fetch it from the API
const data = reverseEnsInterface.encodeFunctionData("getNames", [[address.substring(2)]]);

const response = await fetch(endpoint, {
method: "POST",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify({
jsonrpc: "2.0",
id: "1",
method: "eth_call",
params: [{ to: "0x3671aE578E63FdF66ad4F3E12CC0c0d71Ac7510C", data: data }, "latest"],
}),
});
const web3Provider = new ethers.providers.JsonRpcProvider(mainnetRpcUrl);
const ensName = await web3Provider.lookupAddress(address);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Keyrxng You can test the resolution by hard-coding the address parameter in your local deployment!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it just grabs the first name you have from an array of all the ones you own. I own many, and it picks one consistently that is not my main.

I don't have the proper context to test against the spec but your right actually we both can test it.

@0x4007 what is your main? Which addresses should resolve to which ENS names?

@hhio618 You could provide a screenshot of the name being correctly resolved as QA. Each task should have some kind provided if possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x4007 what is your main? Which addresses should resolve to which ENS names?

アレクサンダー.eth


if (!response.ok) {
if (ensName === null) {
console.error("ENS lookup failed: API request failed");
return "";
}

const ensName = await response.text();

// Store the ENS name in localStorage for future use
localStorage.setItem(address, ensName);

Expand Down
Loading