chore: use generic ubiquity .github/workflows/deploy.yml workflow

[gitcoindev]

Resolves: #712

[whilefoo]

I think you're supposed to use this workflow according to the original issue

[gitcoindev]

I think you're supposed to use this workflow according to the original issue

Aha! This is why I was struggling to run this on my fork, thank you!

[gitcoindev]

I think you're supposed to use this workflow according to the original issue

Aha! This is why I was struggling to run this on my fork, thank you!

After initial analysis I see that since this generic workflow is located outside of the repositories, the logger app could potentially indeed use it. The workflow seems to download build artifact which is available for ubiquibot only as well.

@whilefoo @rndquu do you happen to know how was the logger app deployed before? I assumed it used https://github.com/ubiquity/ubiquibot/blob/development/.github/workflows/deploy-logger-page.yml therefore I copied it over here.

We can implement either solution, just wanted to check the right way to do this.

Solution 1) use https://github.com/ubiquity/ubiquibot/blob/development/.github/workflows/deploy-logger-page.yml (and test that it actually works here as I am quite sure cd ./log-app && npm install && npm run build does not work because build script / target is not defined in package.json)

or solution 2) use the generic workflow and configure build artifacts.

For solution 2) it would be great if you provided link to previous runs (if any) as https://github.com/ubiquity/.github/actions/workflows/deploy.yml says it has never been used before.

[rndquu]

@gitcoindev

After initial analysis I see that since this generic workflow is located outside of the repositories, the logger app could potentially indeed use it.

This generic workflow can be used from any public repository across the whole github regardless of the organization the original (i.e. generic) workflow belongs to.

Do you happen to know how was the logger app deployed before?

I don't actually remember whether the logger app has ever been deployed to one of our servers (i.e. netlify instances).

or solution 2) use the generic workflow and configure build artifacts.

We should use the generic workflow.

For solution 2) it would be great if you provided link to previous runs (if any) as https://github.com/ubiquity/.github/actions/workflows/deploy.yml says it has never been used before.

We use it at least for pay.ubq.fi (example).

[gitcoindev]

Great, thank you @rndquu for clarifications.

[gitcoindev]

@whilefoo @rndquu I updated the pull request to use generic workflow and opened a follow-up ticket #4 to create the build workflow. It would be best to assign the new issue to the app creator or somebody who already deployed the app. There are esbuild bundler configuration files in the scripts folder but there is no README.md on how to build and build step is missing in package.json as well.

[rndquu]

@gitcoindev

Could you:

1. Add the build script to package.json
2. Create a build workflow similar to this one

I will setup everything else regarding the deployment to cloudflare pages because (as far as I understand) it requires access to the ubiquity's cloudflare dashboard.

[gitcoindev]

@rndquu all right, I will take care of this.

[rndquu]

@rndquu all right, I will take care of this.

Thank you

[gitcoindev]

@rndquu @whilefoo I opened #5 to add the build workflow and the build script. I also had to add a few small fixes for typescript code to compile without errors. Plus I updated to the latest node and upgraded dependencies.

[rndquu]

@rndquu @whilefoo I opened #5 to add the build workflow and the build script. I also had to add a few small fixes for typescript code to compile without errors. Plus I updated to the latest node and upgraded dependencies.

I will try to deploy it

[rndquu]

@rndquu @whilefoo I opened #5 to add the build workflow and the build script. I also had to add a few small fixes for typescript code to compile without errors. Plus I updated to the latest node and upgraded dependencies.

I will try to deploy it

Right now the logger app is deployed to cloudflare pages.

We still need to:

1. Apply "read logs" policy (i.e. merge this PR to the bot's main branch)
2. Use bot's prod keys
3. Use a custom domain for the logger app