Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Draft Pull Request not Recognized as Hunter Activity #653

Open
0x4007 opened this issue Aug 22, 2023 · 11 comments · May be fixed by #723
Open

Draft Pull Request not Recognized as Hunter Activity #653

0x4007 opened this issue Aug 22, 2023 · 11 comments · May be fixed by #723
Labels
Price: 25 USD Priority: 2 (Medium) Time: <1 Hour

Comments

@0x4007
Copy link
Member

0x4007 commented Aug 22, 2023 •
edited
Loading

Bounty hunter was adding commits and comments to the draft pull request but the bot still followed up asking for updates.

This should be fixed.

Do you have any updates @devpanther? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Fri Aug 18 2023 05:57:07 GMT+0000 (Coordinated Universal Time)

Originally posted by @ubiquibot in #593 (comment)
@ubiquibot ubiquibot bot mentioned this issue Aug 22, 2023
Closed
@kamaalsultan
Copy link
Contributor

IMO, that's not the problem related to draft. Please check https://github.com/ubiquity/ubiquibot/blob/8646aa11fc9b9edfcc355615a096f12e7935e607/src/helpers/issue.ts#L622C27-L622C27
It fetches commits from a pull request but by default, it only gets first 30 commits.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28
We may need to fetch all the commits from the pull request and check activity of last commit.

@ubiquibot
Copy link

ubiquibot bot commented Aug 23, 2023

Too many assigned issues, you have reached your max of 2

@0x4007
Copy link
Member Author

0x4007 commented Aug 23, 2023 •
edited
Loading

IMO, that's not the problem related to draft. Please check https://github.com/ubiquity/ubiquibot/blob/8646aa11fc9b9edfcc355615a096f12e7935e607/src/helpers/issue.ts#L622C27-L622C27

It fetches commits from a pull request but by default, it only gets first 30 commits.

https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28

We may need to fetch all the commits from the pull request and check activity of last commit.

Thanks for the diagnosis! Looks like the next function loads all of the data. We should consider removing the old function that only loads a single page of data.

Too many assigned issues, you have reached your max of 2

Let's focus on getting one of your previous pull requests merged in. We already made several exceptions for you to take on new tasks, but it's best if you focus your efforts on your previous work (open pull requests) that is not considered completed yet.

@0x4007 0x4007 removed the ping label Aug 29, 2023
@kamaalsultan
Copy link
Contributor

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 5, 2023

Deadline Tue, 05 Sep 2023 10:41:02 UTC
Registered Wallet 0x30fDdD8b3f3a4183734884b6d383da6bf4bf2cd1
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    This was referenced Sep 5, 2023
    Open
    Closed
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 10, 2023

    Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Wed Sep 06 2023 06:37:29 GMT+0000 (Coordinated Universal Time)

    @kamaalsultan
    Copy link
    Contributor

    Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Sep 06 2023 06:37:29 GMT+0000 (Coordinated Universal Time)

    Oh, I had serious toothache so I am starting right now.

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 18, 2023

    Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Wed Sep 13 2023 23:36:49 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 1, 2023

    Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Tue Sep 26 2023 19:00:30 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 8, 2023

    Do you have any updates @ByteBallet? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Wed Oct 04 2023 02:22:13 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 11, 2023

    @ByteBallet - Releasing the bounty back to dev pool because the allocated duration already ended!
    Last activity time: Wed Oct 04 2023 02:22:13 GMT+0000 (Coordinated Universal Time)

    @korrrba-bot korrrba-bot bot mentioned this issue Nov 6, 2023
    Open
    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Assignees
    No one assigned
    Labels
    Price: 25 USD Priority: 2 (Medium) Time: <1 Hour
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    fix: get all commits from pr kamaalsultan/ubiquibot
    2 participants
    @0x4007 @kamaalsultan