-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's way more elements supported. Did you check my draft?
I also added a link to the readme in the last section related to the default config.
I looked at Markdown-to-HTML converter and added all tags that are supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still seems like way too little. I'm not sure what happened to my changes I made to ubiquibot-config-default.json
but perhaps I never merged them in.
https://github.com/pavlovcik/ubiquibot/blob/refactor/general/ubiquibot-config-default.json#L96-L128
You can also see some comments I left when I briefly had it as a .jsonc
file.
According to my vscode: you clobbered my full list addition in https://github.com/ubiquity/ubiquibot/blob/a67607009a2d50fc0d1282ec289478db191ad053/ubiquibot-config-default.json
Last existed in https://github.com/ubiquity/ubiquibot/blob/fc0516e248cbaee4fc3b7c871a4e652d5e836914/ubiquibot-config-default.json
No idea why it doesnt show you deleting it in your commit. Seems that it magically disappeared. Even when directly comparing the history on github https://github.com/ubiquity/ubiquibot/commits/a67607009a2d50fc0d1282ec289478db191ad053/ubiquibot-config-default.json
Comparing bases (...
) its not there 61b4dd0...7c6f399
Three-dot Git diff comparison
The three-dot comparison shows the difference between the latest common commit of both branches (merge base) and the most recent version of the topic branch.
Comparing commits directly (..
) you can see the removal
https://github.com/ubiquity/ubiquibot/compare/61b4dd09b0a91b6d4d763a080b3a616e4a3e5bf4..7c6f399b039a874e93ed99c56925d3f7d998de75
Two-dot Git diff comparison
The two-dot comparison shows the difference between the latest state of the base branch (for example, main) and the most recent version of the topic branch.
I feel like this is a huge problem if code disappears without a trace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the current PR adds html config elements for the comment incentives feature.
When this PR is merged then comment incentives reward calculation is going to work this way (@whilefoo pls correct me if I'm wrong):
- The bot gets and parses comments in
md
format - For each
md
comment node (i.e.Heading
orListItem
) the bot finds the corresponding html config here and applies price accordingly
Overall most of the md
elements are supported (i.e. have their corresponding html tags) which is enough for tweaking comment incentive rewards
Yes that's correct |
@whilefoo can you answer if you included everything possible? According to my reference work, it looks like there are many more supported tags. |
lets add |
now it should support all tags |
will be fixed in #818 |
Related to:
#662 (comment)
#662 (comment)