Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Default config and config change #668

Closed
wants to merge 5 commits into from

Conversation

whilefoo
Copy link
Collaborator

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit be6e517
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/650739e328e8870008ed8194
😎 Deploy Preview https://deploy-preview-668--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@whilefoo whilefoo requested a review from 0x4007 August 25, 2023 10:16
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's way more elements supported. Did you check my draft?

I also added a link to the readme in the last section related to the default config.

https://github.com/syntax-tree/mdast#nodes

@whilefoo
Copy link
Collaborator Author

I looked at Markdown-to-HTML converter and added all tags that are supported.

@whilefoo whilefoo requested a review from 0x4007 August 26, 2023 16:14
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still seems like way too little. I'm not sure what happened to my changes I made to ubiquibot-config-default.json but perhaps I never merged them in.

https://github.com/pavlovcik/ubiquibot/blob/refactor/general/ubiquibot-config-default.json#L96-L128


You can also see some comments I left when I briefly had it as a .jsonc file.

https://github.com/pavlovcik/ubiquibot/blob/691e79df852d718001b58993791eb9aaa5b07223/ubiquibot-config-default.jsonc#L92-L126


According to my vscode: you clobbered my full list addition in https://github.com/ubiquity/ubiquibot/blob/a67607009a2d50fc0d1282ec289478db191ad053/ubiquibot-config-default.json

Last existed in https://github.com/ubiquity/ubiquibot/blob/fc0516e248cbaee4fc3b7c871a4e652d5e836914/ubiquibot-config-default.json

No idea why it doesnt show you deleting it in your commit. Seems that it magically disappeared. Even when directly comparing the history on github https://github.com/ubiquity/ubiquibot/commits/a67607009a2d50fc0d1282ec289478db191ad053/ubiquibot-config-default.json

Comparing bases (...) its not there 61b4dd0...7c6f399
Three-dot Git diff comparison
The three-dot comparison shows the difference between the latest common commit of both branches (merge base) and the most recent version of the topic branch.

Comparing commits directly (..) you can see the removal
https://github.com/ubiquity/ubiquibot/compare/61b4dd09b0a91b6d4d763a080b3a616e4a3e5bf4..7c6f399b039a874e93ed99c56925d3f7d998de75
Two-dot Git diff comparison
The two-dot comparison shows the difference between the latest state of the base branch (for example, main) and the most recent version of the topic branch.

I feel like this is a huge problem if code disappears without a trace.

@0x4007 0x4007 added ping and removed ping labels Aug 29, 2023
rndquu
rndquu previously approved these changes Sep 6, 2023
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the current PR adds html config elements for the comment incentives feature.

When this PR is merged then comment incentives reward calculation is going to work this way (@whilefoo pls correct me if I'm wrong):

  1. The bot gets and parses comments in md format
  2. For each md comment node (i.e. Heading or ListItem) the bot finds the corresponding html config here and applies price accordingly

Overall most of the md elements are supported (i.e. have their corresponding html tags) which is enough for tweaking comment incentive rewards

@whilefoo
Copy link
Collaborator Author

whilefoo commented Sep 7, 2023

Yes that's correct

@0x4007
Copy link
Member

0x4007 commented Sep 10, 2023

@whilefoo can you answer if you included everything possible? According to my reference work, it looks like there are many more supported tags.

@wannacfuture
Copy link
Contributor

lets add pre and ol @whilefoo

@whilefoo
Copy link
Collaborator Author

now it should support all tags

@whilefoo
Copy link
Collaborator Author

will be fixed in #818

@whilefoo whilefoo closed this Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants