This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
fix: stale bounty #670
Merged
fix: stale bounty #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready to start message in /start response
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0x4007
reviewed
Aug 26, 2023
0x4007
suggested changes
Aug 26, 2023
fix config and warning
0x4007
reviewed
Aug 26, 2023
0x4007
reviewed
Aug 26, 2023
uses default json first unless 0 then uses 30d
remove console log and adjust warning
0x4007
reviewed
Aug 27, 2023
|
Reviewing with fresh eyes: Hide the "ready to start" row under normal circumstances, like when the bounty has been created within that same month. It's unnecessary. Change "ready to start" to "warning" And "please confirm that this issue specification is accurate before starting." so that it looks more like a warning. If the organization does not set any "amount of days threshold" in their config, then this feature should gracefully be hidden (the row on the assign table should not render) I delegate my review for the implementation of the config property names etc |
allowing zero input and changed warning
rndquu
suggested changes
Sep 5, 2023
following extraction pattern
whilefoo
suggested changes
Sep 6, 2023
removed null and storing time with number
whilefoo
suggested changes
Sep 7, 2023
whilefoo
suggested changes
Sep 7, 2023
whilefoo
force-pushed
the
start-disclaimer
branch
from
746bde8
to
5e67a76
Compare
whilefoo
suggested changes
Sep 7, 2023
|
@pavlovcik needs your approval |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready to start message in
/startresponse.image
image
Resolves #669