Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: display permission level in /query #707

Merged
merged 9 commits into from
Sep 7, 2023
Merged

feat: display permission level in /query #707

merged 9 commits into from
Sep 7, 2023

Conversation

EtherealGlow
Copy link
Contributor

Resolves #624

@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit 08b7cc0
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/64f9b80859394d0009380f24
😎 Deploy Preview https://deploy-preview-707--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should show permissions from access database table. Also don't forget about QA

@EtherealGlow
Copy link
Contributor Author

@whilefoo i am getting a whole charades of weird errors, mostly Error logging to Supabase: undefined

@EtherealGlow
Copy link
Contributor Author

the bot has worked previously before idk whats happening now

@EtherealGlow
Copy link
Contributor Author

EtherealGlow commented Sep 3, 2023

should i use markup table for displaying all 4 accesses and their levels like

access type access level
multiplier true
priority true
time true
price true

@EtherealGlow
Copy link
Contributor Author

EtherealGlow commented Sep 3, 2023

for now i am gonna assume this

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make a function that retrieve all access levels at the same time to avoid multiple database calls

@0x4007
Copy link
Member

0x4007 commented Sep 4, 2023

Please make sure that CI passes @EtherealGlow

@EtherealGlow
Copy link
Contributor Author

Done

@EtherealGlow
Copy link
Contributor Author

Uhh maybe not 😬

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post QA

src/adapters/supabase/helpers/client.ts Outdated Show resolved Hide resolved
src/adapters/supabase/helpers/client.ts Outdated Show resolved Hide resolved
src/handlers/comment/handlers/query.ts Outdated Show resolved Hide resolved
src/handlers/comment/handlers/query.ts Outdated Show resolved Hide resolved
@EtherealGlow
Copy link
Contributor Author

@whilefoo I can't post the qa because the bot ain't working for me

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubiquity-whilefoo#82 (comment) please fix the table, it's not displaying correctly

@EtherealGlow
Copy link
Contributor Author

ok wait

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's unnecessary to use an external library for a simple table

@EtherealGlow
Copy link
Contributor Author

@whilefoo might work now

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| Command | Description |
| --- | --- |
| git status | List all new or modified files |
| git diff | Show file differences that haven't been staged |

this is how you make a table

@EtherealGlow
Copy link
Contributor Author

should i use markup table for displaying all 4 accesses and their levels like

access type access level
multiplier true
priority true
time true
price true

I did make it here idk why it ain't working there

@EtherealGlow
Copy link
Contributor Author

I am dumb 💀

src/adapters/supabase/helpers/client.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whilefoo whilefoo merged commit e108b49 into ubiquity:development Sep 7, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/query enhancement: show permissions
4 participants