-
Notifications
You must be signed in to change notification settings - Fork 61
feat: display permission level in /query #707
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should show permissions from access
database table. Also don't forget about QA
@whilefoo i am getting a whole charades of weird errors, mostly |
the bot has worked previously before idk whats happening now |
should i use markup table for displaying all 4 accesses and their levels like
|
for now i am gonna assume this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make a function that retrieve all access levels at the same time to avoid multiple database calls
Please make sure that CI passes @EtherealGlow |
Done |
Uhh maybe not 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please post QA
@whilefoo I can't post the qa because the bot ain't working for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubiquity-whilefoo#82 (comment) please fix the table, it's not displaying correctly
ok wait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's unnecessary to use an external library for a simple table
@whilefoo might work now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Command | Description |
| --- | --- |
| git status | List all new or modified files |
| git diff | Show file differences that haven't been staged |
this is how you make a table
I did make it here idk why it ain't working there |
I am dumb 💀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #624