Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

build: making ignoring of children dynamic #825

Open
wants to merge 11 commits into
base: development
Choose a base branch
from

Conversation

GaryThisSidee
Copy link

Resolves #772

@netlify
Copy link

netlify bot commented Sep 24, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit d907861
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/651f0a5258ad2b00082f559c
😎 Deploy Preview https://deploy-preview-825--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GaryThisSidee
Copy link
Author

@whilefoo

src/helpers/comment.ts Outdated Show resolved Hide resolved
src/configs/ubiquibot-config-default.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wannacfuture wannacfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove itemsToExclude prop from parseComments function and just get that information from the config in that function.

src/helpers/comment.ts Outdated Show resolved Hide resolved
src/helpers/comment.ts Outdated Show resolved Hide resolved
src/types/config.ts Outdated Show resolved Hide resolved
@GaryThisSidee
Copy link
Author

@wannacfuture can u take a look

@GaryThisSidee
Copy link
Author

@0xcodercrane can u take a look

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore-children comment incentive config
3 participants