Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Conversation

gitcoindev
Copy link
Contributor

Fix for incorrect knip commands in package.json.

@gitcoindev gitcoindev requested a review from 0x4007 May 30, 2024 07:19
Copy link

Unused files (48)

src/main.ts, src/bindings/event.ts, src/handlers/processors.ts, src/helpers/contracts.ts, src/helpers/label.ts, src/helpers/payout.ts, src/tests/after-all-handler.ts, src/tests/before-all-handler.ts, src/tests/commands-test.ts, src/tests/test-repo-config.ts, src/tests/test-suite.ts, src/tests/utils.ts, src/types/commit.ts, src/types/github-events.ts, src/utils/check-github-rate-limit.ts, src/utils/generate-configuration.ts, src/adapters/github/github-actions.ts, src/handlers/access/labels-access.ts, src/handlers/comment/comment-created.ts, src/handlers/label/label.ts, src/handlers/penalty/add-penalty.ts, src/handlers/pricing/pricing-label.ts, src/handlers/pricing/sync-labels-to-config.ts, src/handlers/pull-request/create-devpool-pr.ts, src/handlers/push/check-modified-base-rate.ts, src/handlers/push/push.ts, src/handlers/push/update-base-rate.ts, src/handlers/shared/pricing.ts, src/handlers/comment/handlers/first.ts, src/handlers/comment/handlers/issue-closed.ts, src/handlers/wildcard/unassign/aggregate-assignee-activity.ts, src/handlers/wildcard/unassign/assign-event-found.ts, src/handlers/wildcard/unassign/check-if-follow-up-already-posted.ts, src/handlers/wildcard/unassign/check-task-to-unassign.ts, src/handlers/wildcard/unassign/check-tasks-to-unassign.ts, src/handlers/wildcard/unassign/disqualify-idle-assignees.ts, src/handlers/wildcard/unassign/get-active-assignees-in-disqualify-duration.ts, src/handlers/wildcard/unassign/get-active-assignees-in-follow-up-duration.ts, src/handlers/wildcard/unassign/get-active-assignees.ts, src/handlers/wildcard/unassign/get-all-commits-from-pull-request.ts, src/handlers/wildcard/unassign/get-all-events.ts, src/handlers/wildcard/unassign/is-correct-type.ts, src/handlers/wildcard/unassign/remind-non-eliminated-assignees.ts, src/handlers/wildcard/unassign/unassign.ts, src/handlers/comment/handlers/delegate-compute/delegated-compute.ts, src/handlers/comment/handlers/delegate-compute/remote-permissions.ts, src/handlers/comment/handlers/issue/get-collaborator-ids-for-repo.ts, src/handlers/comment/handlers/issue/get-pull-request-comments.ts

Unused dependencies (17)

Filename dependencies
package.json @commitlint/cli
@netlify/functions
@octokit/rest
@openzeppelin/contracts
@probot/adapter-github-actions
@typescript-eslint/typescript-estree
@uniswap/permit2-sdk
@vercel/ncc
js-tiktoken
jsdom
libsodium-wrappers
lint-staged
markdown-it
smee-client
tsx
yaml
zlib

Unused devDependencies (7)

Filename devDependencies
package.json @types/jest
@types/jsdom
@types/libsodium-wrappers
@types/markdown-it
@types/source-map-support
octokit
source-map-support

Unused exports (9)

Filename exports
src/helpers/issue.ts addLabelToIssue
addCommentToIssue
src/helpers/shared.ts shouldSkip
src/types/configuration-types.ts validateBotConfig
src/handlers/assign/assign-command-handler.ts assignCommandHandler
src/handlers/assign/check-pull-requests.ts checkPullRequests
src/handlers/pricing/handle-parent-issue.ts handleParentIssue
sortLabelsByValue
src/handlers/comment/handlers/comment-handler-main.ts commentParser

Unused types (7)

Filename types
src/types/handlers.ts WildCardHandler
Handler
src/types/payload.ts GitHubEvent
GitHubCommitsPayload
GitHubAssignEvent
GitHubPushPayload
GithubContent

Unused Enum Members (1)

Filename Enum Member
src/types/payload.ts UserType Organization

Unused Class Members (10)

Filename Class Member
src/adapters/supabase/helpers/tables/label.ts Label saveLabelChange
src/adapters/supabase/helpers/tables/locations.ts Locations locationResponse
user_id
comment_id
issue_id
repository_id
node_id
node_type
src/adapters/supabase/helpers/tables/settlement.ts Settlement addDebit
addCredit

@gentlementlegen
Copy link
Member

gentlementlegen commented May 30, 2024

@gitcoindev Thank you. Knip results are a disaster haha

Also realized that this is merged against main. Are we able to deploy the main branch as the current production Ubiquibot? Afaik this is still not the branch being deployed.

@gitcoindev
Copy link
Contributor Author

@gitcoindev Thank you. Knip results are a disaster haha

Also realized that this is merged against main. Are we able to deploy the main branch as the current production Ubiquibot? Afaik this is still not the branch being deployed.

I have just seen your question and I am not sure about the answer. @0x4007 could you please confirm that this change should be merged into main branch from development branch after merging this pr or a separate pull request to main should be opened?

@0x4007
Copy link
Member

0x4007 commented May 30, 2024

@gitcoindev Thank you. Knip results are a disaster haha
Also realized that this is merged against main. Are we able to deploy the main branch as the current production Ubiquibot? Afaik this is still not the branch being deployed.

I have just seen your question and I am not sure about the answer. @0x4007 could you please confirm that this change should be merged into main branch from development branch after merging this pr or a separate pull request to main should be opened?

Production is actually running off of move-to-delegated-compute

@0x4007 0x4007 changed the base branch from development to refactor/move-to-delegated-compute May 30, 2024 08:45
@gentlementlegen gentlementlegen deleted the branch ubiquity:refactor/move-to-delegated-compute June 7, 2024 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants