test: fix ShouldSetAdminRoleForGivenRole and add test for revert

ubiquity · Jan 19, 2024 · a9df0e2 · a9df0e2
1 parent 0a87fa1
commit a9df0e2
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/packages/contracts/test/diamond/facets/AccessControlFacet.t.sol b/packages/contracts/test/diamond/facets/AccessControlFacet.t.sol
@@ -136,18 +136,24 @@ contract AccessControlFacetTest is DiamondTestSetup {
         assertEq(adminRole, DEFAULT_ADMIN_ROLE);
     }
 
-    // test setRoleAdmin function should set correct admin role
+    function testSetRoleAdmin_ShouldRevertWhenNotAdmin() public {
+        vm.prank(mock_sender);
+
+        vm.expectRevert("Manager: Caller is not admin");
+        accessControlFacet.setRoleAdmin(
+            DOLLAR_TOKEN_BURNER_ROLE,
+            DEFAULT_ADMIN_ROLE
+        );
+    }
+
     function testSetRoleAdmin_ShouldSetAdminRoleForGivenRole() public {
         bytes32 adminRole = accessControlFacet.getRoleAdmin(
             DOLLAR_TOKEN_MINTER_ROLE
         );
-        assertEq(adminRole, DOLLAR_TOKEN_MINTER_ROLE);
+        assertEq(adminRole, DEFAULT_ADMIN_ROLE);
         vm.prank(admin);
-        accessControlFacet.setRoleAdmin(
-            DOLLAR_TOKEN_MINTER_ROLE,
-            DOLLAR_TOKEN_BURNER_ROLE
-        );
+        accessControlFacet.setRoleAdmin(DOLLAR_TOKEN_MINTER_ROLE, PAUSER_ROLE);
         adminRole = accessControlFacet.getRoleAdmin(DOLLAR_TOKEN_MINTER_ROLE);
-        assertEq(adminRole, DOLLAR_TOKEN_BURNER_ROLE);
+        assertEq(adminRole, PAUSER_ROLE);
     }
 }