Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: apply diamond to home and markets pages #784

Closed
Tracked by #783
rndquu opened this issue Aug 29, 2023 · 74 comments · Fixed by #800
Closed
Tracked by #783

UI: apply diamond to home and markets pages #784

rndquu opened this issue Aug 29, 2023 · 74 comments · Fixed by #800

Comments

@rndquu
Copy link
Member

rndquu commented Aug 29, 2023

Original issue

What should be done:

  • take this file and refactor home and markets pages to use contracts from the new diamond architecture
@bojan07
Copy link
Contributor

bojan07 commented Sep 8, 2023

/apply

@ubiquibot
Copy link

ubiquibot bot commented Sep 8, 2023

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /autopay: Toggle automatic payment for the completion of the current issue.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@bojan07

@bojan07
Copy link
Contributor

bojan07 commented Sep 8, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 8, 2023

Deadline Fri, 08 Sep 2023 14:21:55 UTC
Registered Wallet Please set your wallet address to use `/wallet 0x0000...0000`
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 8, 2023

    /wallet 0xbf936aa9aa46a749379fe013adbcb648312465a2

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 8, 2023

    Updated the wallet address for @bojan07 successfully! Your new address: 0xbf936aa9aa46a749379fe013adbcb648312465a2

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 8, 2023

    Hey guys, I have checked the issue description and project repo shortly and I'm interested in solving this issue, but the 4 hours seems too short to me
    Anyways, the issue description is enough for me to start to work on?

    @rndquu
    Copy link
    Member Author

    rndquu commented Sep 12, 2023

    Hey @bojan07

    but the 4 hours seems too short to me

    Increased to 1 day to be on par with other UI related issues (#786, #785)

    Anyways, the issue description is enough for me to start to work on?

    Yes, type the /start command and you're free to solve the issue

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 12, 2023

    Do you have any updates @bojan07? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Fri Sep 08 2023 11:02:06 GMT+0000 (Coordinated Universal Time)

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 12, 2023

    /start

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 12, 2023

    Skipping /start since the issue is already assigned

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 12, 2023

    no blockers for this issue now? @rndquu

    @0x4007
    Copy link
    Member

    0x4007 commented Sep 13, 2023

    @rndquu as we near the end of the year, I would like for you to start ramping up the priority levels on the ubiquity dollar tasks. I would like the new deployment to be complete with a stable UI by end of year.

    This will give us a few months of testing and integrations (like with UbiquiBot and UbiquiCard) before beginning fundraising in March 2024.

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 13, 2023

    Hi @rndquu Is this deployed contracts newly deployed ones? or old ones?
    Current frontend is using the deployed addresses in that file

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 13, 2023

    Hmm, seems I found it. the contract addresses in that file are old ones.. but there is no newly deployed addresses including facets addresses?

    @rndquu
    Copy link
    Member Author

    rndquu commented Sep 14, 2023

    @bojan07

    no blockers for this issue now?

    There are no blockers

    Hi @rndquu Is this deployed contracts newly deployed ones? or old ones?
    Current frontend is using the deployed addresses in that file

    Refactor to make it work in a local anvil instance

    Hmm, seems I found it. the contract addresses in that file are old ones.. but there is no newly deployed addresses including facets addresses?

    Diamond and facets are not deployed yet

    @rndquu
    Copy link
    Member Author

    rndquu commented Sep 14, 2023

    @rndquu as we near the end of the year, I would like for you to start ramping up the priority levels on the ubiquity dollar tasks. I would like the new deployment to be complete with a stable UI by end of year.

    This will give us a few months of testing and integrations (like with UbiquiBot and UbiquiCard) before beginning fundraising in March 2024.

    Ok, I will make it my top priority. The bot's repo really distracts all the time from the Dollar project.

    @bojan07
    Copy link
    Contributor

    bojan07 commented Sep 14, 2023

    /stop

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 3, 2023

    if you did not claim the generated permit, you should wait now

    Yeah, got it.

    @ubiquibot ubiquibot bot added the Permitted label Oct 3, 2023
    @ubiquity ubiquity deleted a comment from ubiquibot bot Oct 3, 2023
    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    if you did not claim the generated permit, you should wait now

    When the reward payment is settled? @molecula451

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    if you did not claim the generated permit, you should wait now

    When the reward payment is settled? @molecula451

    Who is managing this in the team? @pavlovcik @molecula451 @rndquu

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 4, 2023

    /query @bojan07

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 4, 2023

    @bojan07's wallet address is 0x301242a369b997e63b24158a90ce23409ba5c6cf and multiplier is 1

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 4, 2023

    @bojan07 0x301242a369b997e63b24158a90ce23409ba5c6cf is the CEX address, right? If so then pls update your wallet address to the one with a known private key (for example from metamask).

    Generally you should claim rewards but the bot is on some kind of a maintenance mode so we temporary have to transfer rewards manually.

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    @bojan07 0x301242a369b997e63b24158a90ce23409ba5c6cf is the CEX address, right? If so then pls update your wallet address to the one with a known private key (for example from metamask).

    Generally you should claim rewards but the bot is on some kind of a maintenance mode so we temporary have to transfer rewards manually.

    Yeah, got it. thanks

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    So shall I update the wallet address on next bounty? @rndquu if transfer rewards manually, hope you to send to the already registered address

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 4, 2023

    So shall I update the wallet address on next bounty?

    Update the wallet now, I will try to regenerate the reward URL (which can be claimed only from address with a known private key)

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    /wallet 0xc6fa133f3290e14Ad91C7449f8D8101A6f894E25

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 4, 2023

    Updated the wallet address for @bojan07 successfully! Your new address: 0xc6fa133f3290e14Ad91C7449f8D8101A6f894E25

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    But when I claim, I should have native token like eth in my wallet, shouldn't I?

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 4, 2023

    But when I claim, I should have native token like eth in my wallet, shouldn't I?

    Yes, in particular XDAI because rewards are in ERC20 WXDAI for gnosis chain

    There is a facet (not sure if it works though, never tried it) for XDAI which should be enough for you to claim

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    But when I claim, I should have native token like eth in my wallet, shouldn't I?

    Yes, in particular XDAI because rewards are in ERC20 WXDAI for gnosis chain

    There is a facet (not sure if it works though, never tried it) for XDAI which should be enough for you to claim

    Yeah, thanks. Let me check the link

    @rndquu rndquu reopened this Oct 4, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 4, 2023

    @bojan07 please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 20.4 WXDAI will be deducted from your next bounty.

    @rndquu rndquu closed this as completed Oct 4, 2023
    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    There is a facet (not sure if it works though, never tried it) for XDAI which should be enough for you to claim

    Seems this is just faucet(test token)..

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    There is a facet (not sure if it works though, never tried it) for XDAI which should be enough for you to claim

    Seems this is just faucet(test token)..

    No,, real token.. thanks

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 4, 2023

    @bojan07 Generally issue assignees are not eligible for conversation rewards, but since the reward URL is missing you could claim conversation rewards + we owe you 91.8 WXDAI (@pavlovcik )

    Sorry for the mess with the rewards, there was a huge bot's update which we had to revert and now everything is falling apart

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    @bojan07 Generally issue assignees are not eligible for conversation rewards, but since the reward URL is missing you could claim conversation rewards + we owe you 91.8 WXDAI (@pavlovcik )

    Sorry for the mess with the rewards, there was a huge bot's update which we had to revert and now everything is falling apart

    Got it, don't be sorry, thanks

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    @pavlovcik please send the remainder to this ERC-20 address. 0x301242a369b997e63b24158a90ce23409ba5c6cf
    I have lost 105 because I didn't confirm the gnosis network.. 😢

    @0x4007
    Copy link
    Member

    0x4007 commented Oct 4, 2023

    /query @bojan07

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 4, 2023

    @bojan07's wallet address is 0xc6fa133f3290e14Ad91C7449f8D8101A6f894E25 and multiplier is 1

    @0x4007
    Copy link
    Member

    0x4007 commented Oct 4, 2023

    It will be sent to 0xc6fa133f3290e14Ad91C7449f8D8101A6f894E25 because you successfully claimed there

    @0x4007
    Copy link
    Member

    0x4007 commented Oct 4, 2023

    https://gnosisscan.io/tx/0x0f99a654ced7b700daab05ac649255c0a69402a8f900f5d9a1e68047a40cc575

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    6 participants