Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply diamond to home and market pages #800

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

bojan07
Copy link
Contributor

@bojan07 bojan07 commented Oct 2, 2023

Resolves #784

@ubiquibot
Copy link

ubiquibot bot commented Oct 2, 2023

@bojan07 bojan07 marked this pull request as ready for review October 2, 2023 13:26
@bojan07
Copy link
Contributor Author

bojan07 commented Oct 2, 2023

@rndquu This PR is ready for a review

@ubiquibot ubiquibot bot closed this Oct 2, 2023
@rndquu rndquu reopened this Oct 2, 2023
@rndquu rndquu self-requested a review October 2, 2023 16:19
@bojan07 bojan07 force-pushed the development branch 2 times, most recently from 2d96edd to b1b2bc2 Compare October 2, 2023 19:31
@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

@molecula451 when the review can be done? hope it will be done soon in order for me to avoid conflicts from further updates

@molecula451
Copy link
Member

molecula451 commented Oct 3, 2023

@bojan07 can you test the changes locally and provide a visual context of the facets being fetched? e.g the addresses at dev console on the browser, this will require you to start:anvil and deploy:development the contracts

@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

@bojan07 can you test the changes locally and provide a visual context of the facets being fetched? e.g the addresses at dev console on the browser, this will require you to start:anvil and deploy:development the contracts

Ok, np

@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

image
image
I can get the addresses deployed on anvil testnet on browser dev console, but calling diamond function failing.. weird

@molecula451
Copy link
Member

I can get the addresses deployed on anvil testnet on browser dev console, but calling diamond function failing.. weird

debug and fix

@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

I can get the addresses deployed on anvil testnet on browser dev console, but calling diamond function failing.. weird

debug and fix

Is there a way to check if the contract function of the facet is working right?

@molecula451
Copy link
Member

Is there a way to check if the contract function of the facet is working right?

We have clean tests

When you do yarn test:all forge will have a lot of debugging info

@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

Is there a way to check if the contract function of the facet is working right?

We have clean tests

When you do yarn test:all forge will have a lot of debugging info

Good

@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

image
Working well with current codebase.. the error came out because I haven't added anvil testnet in my metamask and haven't used localnet. I think

@bojan07
Copy link
Contributor Author

bojan07 commented Oct 3, 2023

Exactly. When I changed the network to mainnet in my metamask, that error happened, but when changing to local net again, the error disappeared.. 💪💪💪

Due to shit thing, wasted 3 hours 🤦‍♂️

@molecula451
Copy link
Member

Good to merge.

There are small bug fixes that are not part of the issue, like set env to "debug" to avoid fetching these addresses on mainnet and avoid the revert call, this will be fixed soon

@molecula451 molecula451 merged commit d41cc0d into ubiquity:development Oct 3, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: apply diamond to home and markets pages
3 participants