-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply diamond to home and market pages #800
Conversation
@rndquu This PR is ready for a review |
2d96edd
to
b1b2bc2
Compare
@molecula451 when the review can be done? hope it will be done soon in order for me to avoid conflicts from further updates |
@bojan07 can you test the changes locally and provide a visual context of the facets being fetched? e.g the addresses at dev console on the browser, this will require you to |
Ok, np |
debug and fix |
Is there a way to check if the contract function of the facet is working right? |
We have clean When you do |
Good |
Exactly. When I changed the network to mainnet in my metamask, that error happened, but when changing to local net again, the error disappeared.. 💪💪💪 Due to shit thing, wasted 3 hours 🤦♂️ |
Good to merge. There are small bug fixes that are not part of the issue, like set env to "debug" to avoid fetching these addresses on mainnet and avoid the revert call, this will be fixed soon |
Resolves #784