Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: apply diamond to staking page #785

Closed
Tracked by #783
rndquu opened this issue Aug 29, 2023 · 16 comments · Fixed by #804
Closed
Tracked by #783

UI: apply diamond to staking page #785

rndquu opened this issue Aug 29, 2023 · 16 comments · Fixed by #804

Comments

@rndquu
Copy link
Member

rndquu commented Aug 29, 2023

Original issue

What should be done:

  • take this file and refactor the staking page to use contracts from the new diamond architecture
@bojan07
Copy link
Contributor

bojan07 commented Oct 2, 2023

/apply

@bojan07
Copy link
Contributor

bojan07 commented Oct 2, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Oct 2, 2023

Too many assigned issues, you have reached your max of 2

@bojan07
Copy link
Contributor

bojan07 commented Oct 2, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Oct 2, 2023

Deadline Tue, 03 Oct 2023 13:45:14 UTC
Registered Wallet 0x301242a369b997e63b24158a90ce23409ba5c6cf
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 2, 2023

    I have one question
    DebtCouponManager has changed into creditNftManager, right? @rndquu
    And these names in the current ui codebase should be changed into creditNftManager too?

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 2, 2023

    DebtCouponManager has changed into creditNftManager, right?

    DebtCouponManager was renamed to CreditNftManagerFacet

    And these names in the current ui codebase should be changed into creditNftManager too?

    Yes, I think creditNftManagerFacet is even more appropriate than creditNftManager

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 3, 2023

    @rndquu dollar3poolMarket and _3crvToken can also be added to protocol contract?
    image

    @rndquu
    Copy link
    Member Author

    rndquu commented Oct 3, 2023

    @rndquu dollar3poolMarket and _3crvToken can also be added to protocol contract?

    Yes, can't think of a better place for them right now

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    @rndquu @molecula451 this pr is ready for a review

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    /wallet 0xc6fa133f3290e14Ad91C7449f8D8101A6f894E25

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 4, 2023

    Updated the wallet address for @bojan07 successfully! Your new address: 0xc6fa133f3290e14Ad91C7449f8D8101A6f894E25

    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 4, 2023

    I'm ready to push commits for credit page issue.. hope the review can be done asap, so that I can avoid any conflicts 💪

    @ubiquity ubiquity deleted a comment from Keyrxng Oct 5, 2023
    @ubiquity ubiquity deleted a comment from ubiquibot bot Oct 5, 2023
    @ubiquity ubiquity deleted a comment from Keyrxng Oct 5, 2023
    @ubiquity ubiquity deleted a comment from ubiquibot bot Oct 5, 2023
    @bojan07
    Copy link
    Contributor

    bojan07 commented Oct 7, 2023

    When can the review be done? I hope the review of at least one of these two(pr804, pr809) can be done today, so that I can move on next issue. Due to limitation of assigning, I can't move on

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 12, 2023

    Task Assignee Reward

    [ CLAIM 200 WXDAI ]

    0xc6fa133f...A6f894E25

    If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
    We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

    @ubiquibot
    Copy link

    ubiquibot bot commented Oct 12, 2023

    Task Creator Reward

    rndquu: [ CLAIM 17.1 WXDAI ]

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    3 participants