-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create tsx for cow zap transaction #734
feat: create tsx for cow zap transaction #734
Conversation
Working on the tests. It's a super simple contract for facilitating the zap. Just need to get the Ubiquity Pool setup to do it. |
Can you elaborate on what you mean by this? |
The contracts are what is called by CoW Protocol to interact with the UbiquityPoolFacet contract. The setup from the previous tests worked so it really didn't take much. |
i am drafting this PR as it looks it needs more work to be done, @hashedMae request review when you really think you accomplish the task |
@rndquu there might be some progress here! but I think this PR, in it's actual stage doesn't solve the issue #610
I think we should close in favor of some thoughts from the hunter (means give some time to the hunter to provide some thoughts) |
I don't understand why you set this PR as ready for review from the draft state
It's actually handled automatically by the bot so let the bot does his job |
It's supposed to but it missed this one due to the pagination issue. It unassigned mae two weeks ago. I'll close for it being stale. |
Resolves #610