Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create tsx for cow zap transaction #734

Conversation

hashedMae
Copy link
Contributor

Resolves #610

@ubiquibot
Copy link

ubiquibot bot commented Jul 17, 2023

@hashedMae hashedMae marked this pull request as ready for review July 18, 2023 20:25
@hashedMae
Copy link
Contributor Author

Working on the tests. It's a super simple contract for facilitating the zap. Just need to get the Ubiquity Pool setup to do it.

@0x4007
Copy link
Member

0x4007 commented Jul 27, 2023

Just need to get the Ubiquity Pool setup to do it.

Can you elaborate on what you mean by this?

@0x4007 0x4007 mentioned this pull request Jul 27, 2023
@hashedMae
Copy link
Contributor Author

Just need to get the Ubiquity Pool setup to do it.

Can you elaborate on what you mean by this?

The contracts are what is called by CoW Protocol to interact with the UbiquityPoolFacet contract. The setup from the previous tests worked so it really didn't take much.

@molecula451
Copy link
Member

i am drafting this PR as it looks it needs more work to be done, @hashedMae request review when you really think you accomplish the task

@molecula451 molecula451 marked this pull request as draft July 31, 2023 17:42
@0x4007 0x4007 added ping and removed ping labels Aug 9, 2023
@molecula451 molecula451 marked this pull request as ready for review August 11, 2023 16:12
@molecula451
Copy link
Member

molecula451 commented Aug 11, 2023

@rndquu there might be some progress here! but I think this PR, in it's actual stage doesn't solve the issue #610

  1. Should we close?
  2. Should we give an opportunity to the worker with new thoughts, etc? and no dismiss the progress

I think we should close in favor of some thoughts from the hunter (means give some time to the hunter to provide some thoughts)

@rndquu
Copy link
Member

rndquu commented Aug 11, 2023

@rndquu there might be some progress here! but I think this PR, in it's actual stage doesn't solve the issue #610

  1. Should we close?
  2. Should we give an opportunity to the worker with new thoughts, etc? and no dismiss the progress

I think we should close in favor of some thoughts from the hunter (means give some time to the hunter to provide some thoughts)

I don't understand why you set this PR as ready for review from the draft state

I think we should close in favor of some thoughts from the hunter

It's actually handled automatically by the bot so let the bot does his job

@0x4007
Copy link
Member

0x4007 commented Aug 12, 2023

It's actually handled automatically by the bot so let the bot does his job

It's supposed to but it missed this one due to the pagination issue. It unassigned mae two weeks ago. I'll close for it being stale.

@0x4007 0x4007 closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ZAP to collateral contract
4 participants