feat: add protocol contracts export helper #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so I see this was your initial vision, make it pass build so I may appropiately test it |
|
Working and fetching the diamond
but judging by this. The ultimate decision it's get rid of the hook? |
molecula451
approved these changes
Aug 23, 2023
This was referenced Aug 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #731
We migrated to the diamond proxy pattern some time ago and right now the UI is broken because we need to refactor all "get contract" hooks (along with pages and components) accordingly.
This PR creates a helper file that exports:
The next step would be to take this file and refactor all of the frontend pages to use contracts from that file (to make sure that everything works fine at least on a local anvil instance):