chore: check core contracts storage changes on pr #789
Conversation
There was a problem hiding this comment.
Overall works fine for the following checklist:
- success: new variable added to the end of a contract
- fail: new state variable introduced in the beginning or in the middle of a contract
- fail: order of state variables changed
- fail: type of state variable changed
- fail: existing state variable removed from the middle of a contract
- fail: existing state variable removed from the end of a contract
- fail: inheritance changed, ex:
contract MyContract is A,B != contract MyContract is B,A - fail: new state variable added to the base contract
The https://github.com/Rubilmax/foundry-storage-check workflow throws a false positive when a new state variable is added to a base contract and the gap size is reduced but we can put up with it.
There was a problem hiding this comment.
I have merged the whole thing to my forked branch, and I can replicate.
Working good
Yes. there is NO issue merging this in it's current stage, as it should pass everything when it's merged
My QA:
action running with no triggers
https://github.com/molecula451/ubiquity-dollar/actions/runs/6288841260
action running with trigger
https://github.com/molecula451/ubiquity-dollar/actions/runs/6288943288/job/17074938660
One thing: I will favor the deprecation warning by github about the "set-output" and fix it
[provide_contracts](https://github.com/molecula451/ubiquity-dollar/actions/runs/6288841260/job/17074756015#step:4:8)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
@gitcoindev korba please rebase branch and update it |
GitHub UI allows me to directly merge the pull request. If you want I can do it for you |
Resolves: #775
This GitHub action checks pull requests for all core contracts storage changes.