Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/move ubiquistick #798

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Refactor/move ubiquistick #798

merged 3 commits into from
Oct 2, 2023

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Oct 2, 2023 •
edited
Loading

This PR:

  1. Moves UbiquiStick deploy from UUPSTestHelper to a single test where it is used
  2. Fixes bug when ERC1155 tokens are minted instead of ERC721 UbiquiStick
  3. Makes ERC1155Ubiquity contract abstract to be on par with ERC20Ubiquity

Test coverage CI is failing but there are only code refactors.

Storage Check CI is also failing with the API rate limit error. Not sure what's causing it, I'll check it. Anyway this PR doesn't modify storage in any of the contracts.

@rndquu rndquu marked this pull request as ready for review October 2, 2023 08:38
@gitcoindev
Copy link
Contributor

Hi @rndquu the repository likely crosses 1000 requests per hour limit.

Rate limits for requests from GitHub Actions
When using GITHUB_TOKEN , the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

molecula451
molecula451 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@molecula451
Copy link
Member

ci looks generic, hopefully we get a fix asap

@rndquu rndquu merged commit bcb66d3 into ubiquity:development Oct 2, 2023
12 of 35 checks passed
@rndquu rndquu deleted the refactor/move-ubiquistick branch October 2, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molecula451 molecula451 molecula451 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rndquu @gitcoindev @molecula451