Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: using foundry from 2 Oct 2023 #805

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Oct 4, 2023

This PR sets foundry toolchain action for the version dated on 28 Sep 2023.

This is the closest release with the vm.parseJsonKeys feature (which is needed for this issue).

Chances are that this release will be removed in the future (because it is pretty much a fresh one and foundry tends to delete releases from time to time) but I haven't found any other ones with the vm.parseJsonKeys feature.

@ubiquibot
Copy link

ubiquibot bot commented Oct 4, 2023

@rndquu rndquu marked this pull request as ready for review October 4, 2023 08:06
@molecula451
Copy link
Member

molecula451 commented Oct 4, 2023

so we need it for #616 good catch @rndquu, but we shouldn't rely on fresh release, they act fast, it will broke the CI

@rndquu
Copy link
Member Author

rndquu commented Oct 4, 2023

so we need it for #616 good catch @rndquu, but we shouldn't rely on fresh release, they act fast, it will broke the CI

I don't have other ideas except simply using the latest nightly build which also might break the CI

@molecula451
Copy link
Member

and also if it breaks, then we change the CI, it will break the implementantion, what about we wait for a proper release and postpone #616

@gitcoindev
Copy link
Contributor

Yes, in such cases staging area is helpful. Foundry has been always 'nightly' so far but some nightlies are marked as pre-release.

I had a quick look and since the previous used version changes can be analyzed here

foundry-rs/foundry@nightly-d369d2486f85576eec4ca41d277391dfdae21ba7...nightly-96ab9131e6735df35aca0249968c7d339590de20

The version selected by @rndquu was fortunately selected / pinned recently as a pre-release https://github.com/foundry-rs/foundry/tags vs https://github.com/foundry-rs/foundry/releases (see the pre-release label on 28th September) so it might have a chance for survival.

@molecula451
Copy link
Member

judging by the #803 i will consider #616 as breaking even tho it's labeled as a small task, we could give it a try but when we have to deal with reverts PR (in extreme cases) because rndqnuu changes a lot of things at #803

@rndquu
Copy link
Member Author

rndquu commented Oct 5, 2023

mgid_arc_imageassetref_shared southpark us

https://github.com/foundry-rs/foundry/releases/tag/nightly-96ab9131e6735df35aca0249968c7d339590de20

@molecula451
Copy link
Member

this release https://github.com/foundry-rs/foundry/releases/tag/nightly-96ab9131e6735df35aca0249968c7d339590de20 mentioned by rndqnuu in this PR was just removed

@molecula451
Copy link
Member

lol notice at the same time

@molecula451
Copy link
Member

but yeah i mean, i don't think you want to stale #616 and judging by when we found "stable" commit it was months, so i think it will take a few months to have a stable with the new implementation vm.parseJsonKey

@rndquu
Copy link
Member Author

rndquu commented Oct 5, 2023

but yeah i mean, i don't think you want to stale #616 and judging by when we found "stable" commit it was months, so i think it will take a few months to have a stable with the new implementation vm.parseJsonKey

I'm refactoring the deployment script and this issue is a part of this refactoring

@rndquu
Copy link
Member Author

rndquu commented Oct 5, 2023

Ok, right now foundry release from 30 Sep is set, let's wait for a couple of days. If it is not removed then I will merge the current PR because I really need the vm.parseJsonKeys feature.

@molecula451
Copy link
Member

we can deal with fixes if they come by

@gitcoindev
Copy link
Contributor

Interestingly I noticed that previously they kept always pre-release from 2nd day of a month. If this is still the case the one from October 2nd will stay. Let's see.

@molecula451 molecula451 changed the title ci: use foundry from Sep 2023 ci: using foundry from 2 Oct 2023 Oct 7, 2023
@gitcoindev
Copy link
Contributor

2nd Oct 2023 release seems to have survived till now 🎉

@rndquu rndquu merged commit 000bdb6 into ubiquity:development Oct 12, 2023
18 checks passed
@rndquu rndquu deleted the ci/foundry-sep-23 branch October 12, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants