-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate coverage script #864
Conversation
looks like rndquu introduced an update in favor of forge coverage |
It will be interesting to find out why the coverage value was wrong. If I am not mistaken it was detected during recent audit. I found out that the original solution was introduced in #637 and was implemented based on the workaround in a still open foundry issue: foundry-rs/foundry#2988 (comment) |
to clarify things, the first coverage.sh (which is rndquu mentions that he gets wrong) output it's the output that you get after run it in a clean clone development branch, not the forwared repo for the audit etc.., the second too it's clean branch here dollar/development |
We urgently needed a working If |
Indeed, GitHub actions do not use it. |
Resolves #862
This PR deprecates the coverage.sh script that resides in the contract folder, rndqnuu doesn't seem to get the actual results and also we do have forge coverage that output different results to.
So if this PR gets in it will be a deprecation in favor of forge coverage
If the PR doesn't get in the coverage.sh will still resides, altho there is a workflow that does it and the issue would be closed as not planned
coverage.sh results on latest development branch
forge coverage results on latest development branch