chore: limit diamond storage check API calls #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrow down test matrix scope to changed Dollar libraries Resolves: ubiquity#876
rndquu
approved these changes
Jan 24, 2024
|
I will now revert #878 , after that we should sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrow down test matrix scope to changed Dollar libraries
Resolves: #876
QA: Changed 5 files in a dummy PR, 3 files are libraries with storage, only those were picked up to be analyzed.
https://github.com/gitcoindev/ubiquity-dollar/pull/15/files#diff-3c2e3163820394bdd79dac50e9c8f83d7938e2f0b8354d5214b04b4798b114f8
GitHub diamond storage check action triggered only on 3 libraries:
https://github.com/gitcoindev/ubiquity-dollar/actions/runs/7638730341
After this pull request is accepted and merged, #878 can be reverted.