-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update config and a default wallet connect key #888
Merged
molecula451
merged 7 commits into
ubiquity:development
from
molecula451:fix-walletconnect
Jan 27, 2024
Merged
chore: update config and a default wallet connect key #888
molecula451
merged 7 commits into
ubiquity:development
from
molecula451:fix-walletconnect
Jan 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molecula451
changed the title
chore: update config and wallet connect
chore: update config and a default wallet connect key
Jan 26, 2024
Hi @molecula451 I see the build is broken, could you please try to fix this? I will do the review today.
|
fixed at d02ce8a missed the latest change and push |
gitcoindev
requested changes
Jan 26, 2024
btw i generated the key myself so its not something that its laying around the web lol |
gitcoindev
approved these changes
Jan 26, 2024
rndquu
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #815
This fixes the "annoying" invalid key error anytime the local env or the whole dapp env does not read the WalletConnect Key, this key is free and it can be generate many times, so no a security concern