Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update config and a default wallet connect key #888

Merged
merged 7 commits into from
Jan 27, 2024
Merged

chore: update config and a default wallet connect key #888

merged 7 commits into from
Jan 27, 2024

Conversation

molecula451
Copy link
Member

@molecula451 molecula451 commented Jan 26, 2024

Refer #815

This fixes the "annoying" invalid key error anytime the local env or the whole dapp env does not read the WalletConnect Key, this key is free and it can be generate many times, so no a security concern

Screenshot from 2024-01-26 12-38-17

@molecula451 molecula451 changed the title chore: update config and wallet connect chore: update config and a default wallet connect key Jan 26, 2024
@molecula451 molecula451 marked this pull request as ready for review January 26, 2024 16:47
@gitcoindev
Copy link
Contributor

Hi @molecula451 I see the build is broken, could you please try to fix this? I will do the review today.

Failed to compile.
./components/lib/hooks/use-web-3.tsx:12:23
Type error: Cannot find module 'ubq-connect.config' or its corresponding type declarations.

@molecula451
Copy link
Member Author

Hi @molecula451 I see the build is broken, could you please try to fix this? I will do the review today.

fixed at d02ce8a missed the latest change and push

packages/dapp/tsconfig.json Outdated Show resolved Hide resolved
@molecula451
Copy link
Member Author

btw i generated the key myself so its not something that its laying around the web lol

@molecula451 molecula451 merged commit 38c3656 into ubiquity:development Jan 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants