Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow to mint dollar when collateral is equal to zero #892

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Do not allow to mint dollar when collateral is equal to zero #892

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f3ffea
fix: do not allow to mint dollar with zero collateral
gitcoindev Feb 2, 2024
33d0fa1
test: add testMintDollar_ShouldRevert_IfZeroCollateralAvailable
gitcoindev Feb 2, 2024
8efd07f
test: update comment in zero collateral mint test
gitcoindev Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ library LibUbiquityPool {

// get amount of collateral for minting Dollars
collateralNeeded = getDollarInCollateral(collateralIndex, dollarAmount);
require(collateralNeeded > 0, "Cannot mint with zero collateral");
gitcoindev marked this conversation as resolved.
Show resolved Hide resolved

// subtract the minting fee
totalDollarMint = dollarAmount
Expand Down
21 changes: 21 additions & 0 deletions packages/contracts/test/diamond/facets/UbiquityPoolFacet.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,27 @@ contract UbiquityPoolFacetTest is DiamondTestSetup {
);
}

function testMintDollar_ShouldRevert_IfZeroCollateralAvailable() public {
gitcoindev marked this conversation as resolved.
Show resolved Hide resolved
vm.prank(admin);
ubiquityPoolFacet.setPriceThresholds(
1000000, // mint threshold
1000000 // redeem threshold
);
// reset collateral fees to 0
vm.prank(admin);
ubiquityPoolFacet.setFees(0, 0, 0);

// user sends 100 collateral tokens and gets 100 Dollars
vm.prank(user);
vm.expectRevert("Cannot mint with zero collateral");
ubiquityPoolFacet.mintDollar(
0, // collateral index
0, // Dollar amount
100e18, // min amount of Dollars to mint
0 // max collateral to send
);
}

function testMintDollar_ShouldRevert_OnDollarAmountSlippage() public {
vm.prank(admin);
ubiquityPoolFacet.setPriceThresholds(
Expand Down
Loading