Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use msg.sender on Ubiquistick NFT mint #911

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix: use msg.sender on Ubiquistick NFT mint #911

merged 1 commit into from
Mar 4, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Mar 4, 2024

@rndquu rndquu marked this pull request as ready for review March 4, 2024 12:37
gitcoindev
gitcoindev approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, implemented according to Sherlock's finding and suggestion to fix. Approved from my side.

@molecula451 molecula451 merged commit d2378a3 into ubiquity:development Mar 4, 2024
14 checks passed
@rndquu rndquu deleted the fix/audit-issue-156 branch March 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitcoindev gitcoindev gitcoindev approved these changes

@molecula451 molecula451 molecula451 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

popelev - Anyone can deposit to protocol tokens of other users without approve
3 participants
@rndquu @molecula451 @gitcoindev