Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(migration): deploy collateral in testnet #920

Merged
merged 2 commits into from
Mar 28, 2024
Merged

refactor(migration): deploy collateral in testnet #920

merged 2 commits into from
Mar 28, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Mar 25, 2024

This PR refactors migration script:

  • for mainnet we use LUSD collateral token (read its address from env variable)
  • for testnet/anvil we deploy collateral token from scratch (for ease of debugging)

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 25, 2024 •
edited
Loading

@rndquu rndquu marked this pull request as ready for review March 25, 2024 08:50
@rndquu rndquu requested a review from gitcoindev March 25, 2024 08:50
@rndquu rndquu marked this pull request as draft March 27, 2024 08:30
@rndquu rndquu marked this pull request as ready for review March 27, 2024 08:37
@rndquu rndquu requested a review from molecula451 March 27, 2024 08:37
molecula451
molecula451 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues so far, just a quick update

@rndquu rndquu merged commit 501e69f into ubiquity:development Mar 28, 2024
13 checks passed
@rndquu rndquu deleted the refactor/testnet-deploy-collateral branch March 28, 2024 06:52
gitcoindev
gitcoindev reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed after merging, was driving a long trip yesterday. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitcoindev gitcoindev gitcoindev left review comments

@molecula451 molecula451 molecula451 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rndquu @molecula451 @gitcoindev