Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/curve migration #921

Merged
merged 6 commits into from
Mar 30, 2024
Merged

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Mar 28, 2024

This PR refactors mainnet migrations to eliminate manual steps like:

P.S. I've tested the migration against the anvil forked from mainnet with this test file which passed successfully

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 28, 2024

@gitcoindev
Copy link
Contributor

Hi @rndquu i did an initial review, thank you for the comments explaining some values (e.g. ln(2) to calc time). I have not tested it yet. Do you plan to rework and merge together with UI changes?

@rndquu
Copy link
Member Author

rndquu commented Mar 28, 2024

Hi @rndquu i did an initial review, thank you for the comments explaining some values (e.g. ln(2) to calc time). I have not tested it yet. Do you plan to rework and merge together with UI changes?

The plan is to prepare the mainnet deployment script so that @pavlovcik could run yarn deploy:mainnet from ubq.eth EOA and be done with the deployment.

Right now the redeployment plan is this one:

  1. Manually remove ~27k 3CRV tokens from the old Curve metapool (https://etherscan.io/address/0x20955CB69Ae1515962177D164dfC9522feef567E)
  2. Setup env variables (in particular private key for ubq.eth EOA) and run yarn deploy:mainnet from https://github.com/ubiquity/ubiquity-dollar which:
    a) deploys Dollar and Diamond contracts
    b) mints initial Dollar tokens for ubq.eth EOA
    c) deploys Curve's metapool
  3. Manually add liquidity (Dollar + 3CRV) to the deployed metapool

Overall the deployment script is ready, I will run a few tests tomorrow of the deployed contracts on the forked state.

Do you plan to rework and merge together with UI changes?

UI requires metapool to be deployed for it to work on the mainnet. So the plan is to prepare the mainnet deployment, check how it works, apply it and then update UI.

@rndquu rndquu marked this pull request as ready for review March 30, 2024 09:53
Copy link
Member

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to launch team 🚀

Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an another review round and approving as well from my side.

@gitcoindev gitcoindev merged commit b595120 into ubiquity:development Mar 30, 2024
13 checks passed
@rndquu rndquu deleted the feat/curve-migration branch April 1, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants