Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fractional pool #922
Feat/fractional pool #922
Changes from 3 commits
527db32
d145f3a
abd3024
5fc9468
535dafb
8b3bfb1
a9cd4a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 52 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check failure on line 54 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check failure on line 56 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check warning on line 58 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
Check failure on line 60 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check failure on line 65 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check warning on line 67 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
Check failure on line 69 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check failure on line 71 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check failure on line 73 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Variable diff
Check warning on line 75 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
Check warning on line 80 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
Check warning on line 82 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
Check warning on line 87 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
Check warning on line 89 in packages/contracts/src/dollar/libraries/LibUbiquityPool.sol
GitHub Actions / check_storage_layout (src/dollar/libraries/LibUbiquityPool.sol:LibUbiquityPool)
Label diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LOW] - Collateral ratio should be capped
As seen in Frax's code, collateral ratio will always be capped at 100%. For Ubiquity, if a higher value is wrongly set and the dynamic CR is implemented, then it could cause some issues. It is recommended to add a maximum value for
newCollateralRatio
of 1_000_000.It would also be good to cap the fees in the
setFees
function to the max acceptable values, as well as the redemption delay blocks insetRedemptionDelayBlocks
.