Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fractional mainnet migration #924

Merged
merged 3 commits into from
Apr 11, 2024
Merged

feat: fractional mainnet migration #924

merged 3 commits into from
Apr 11, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Apr 9, 2024 •
edited
Loading

This PR refactors mainnet and development migrations to reflect changes introduced in #922

The main changes are:

  1. Curve's Governance-WETH crypto pool:
  1. Chainlink price feed for ETH/USD pair:
  1. Small updates like setting collateral ratio to 95% from start, calling some necessary setters, etc...

P.S. All tests are passed for anvil instance forked from mainnet in this test file

@rndquu rndquu changed the title refactor: use a single migration feat: fractional mainnet migration Apr 9, 2024
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Apr 9, 2024 •
edited
Loading

@rndquu rndquu marked this pull request as ready for review April 11, 2024 12:55
gitcoindev
gitcoindev approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side, just added a few notes / comments. Good job!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
packages/contracts/migrations/development/Deploy001_Diamond_Dollar_Governance.s.sol Show resolved Hide resolved
packages/contracts/migrations/mainnet/Deploy001_Diamond_Dollar_Governance.s.sol Show resolved Hide resolved
packages/contracts/migrations/mainnet/Deploy001_Diamond_Dollar_Governance.s.sol Show resolved Hide resolved
packages/contracts/migrations/mainnet/Deploy001_Diamond_Dollar_Governance.s.sol Show resolved Hide resolved
molecula451
molecula451 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean & Clear PR

@molecula451 molecula451 merged commit 2eddcfb into ubiquity:development Apr 11, 2024
13 checks passed
@rndquu rndquu deleted the feat/migration-fractional branch April 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitcoindev gitcoindev gitcoindev approved these changes

@molecula451 molecula451 molecula451 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rndquu @molecula451 @gitcoindev