feat: add ICurveStableSwapNG #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementation-wise looks perfect, I will wait for the security research with his review before approval to merge. |
|
Everything looks correct, the issue is properly fixed |
gitcoindev
approved these changes
Apr 24, 2024
molecula451
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #931
This PR refactors LibUbiquityPool to use ICurveStableSwapNG instead of ICurveStableSwapMetaNG.
ICurveStableSwapMetaNGis basically aDollar/3CRVpool. Keeping in mind that3CRVis equal to$1.03we can't reliably fetch Dollar price in USD fromICurveStableSwapMetaNG.We plan to create a new
ICurveStableSwapNGpool withLUSD/Dollarpair. So calculating Dollar price in USD works this way:LUSD/USDprice from chainlinkDollar/LUSDprice from Curve'sICurveStableSwapNGoracleDollar/USDpriceP.S. Deployment scripts will be updated in a separate PR