Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip check_storage_layout check if provide_contracts job retur… #948

Merged

Conversation

gitcoindev
Copy link
Contributor

Prevent fromJSON failure in check storage layout workflows by checking provide_contracts output before triggering matrix strategy.

Resolves: #942

QA on my fork: https://github.com/gitcoindev/ubiquity-dollar/actions/runs/9686630787/job/26729492711?pr=22

Based on 'How to handle empty matrix' solution for dorny/paths-filter#66

…ns empty array

Prevent fromJSON failure by checking provide_contracts output before
triggering matrix strategy.

Resolves: ubiquity#942
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jun 26, 2024

Copy link
Member

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the matrix strategy was trying decode a fromJson empty values thus clogging the CI. Checked and this fixed the issue indeed

@rndquu rndquu merged commit cea94a0 into ubiquity:development Jun 27, 2024
12 checks passed
@rndquu rndquu deleted the fix-storage-collision-workflows branch June 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: fix storage collision workflows
3 participants