Issue 927 security monitor #950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linter: update eslint flag
ci: using foundry from 2 Oct 2023
* fix: match contract type according to diamond architecture
chore: remove unused
* test: some fixes
* fix: removed protocolcontracts in dependencies to avoid infinite loop
…ents (#824) * fix(review): updated contract names
refactor: update creditclock to facet
* refactor(deploy): get CreditClockFacet selectors dynamically
We need this deployed by New Year's Eve.
As requested during pull request review.
feat: UbiquityPoolFacet fuzz tests
chore: RPC update
…ns empty array Prevent fromJSON failure by checking provide_contracts output before triggering matrix strategy. Resolves: #942
chore: skip check_storage_layout check if provide_contracts job retur…
it is not, this is unnaceptable, fork and clean branch and work from there |
|
it isnt letting me merge to developement branch is there a specific branch i should be comparing too? |
|
you have to fork the branch https://github.com/ubiquity/ubiquity-dollar/ and make changes there, then send PR |
|
oh ok i thought i was supposed to create a draft before making any commits |
|
looks like you selected "main" branch which is no update, please select "development" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #927 #927