Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an addresses table to README #977

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Nov 6, 2024

At this task in a neighbor repo we agreed it was a good idea to have an addresses table to aggregate deployment information. Perhaps this could be handy here too. Take it as a suggestion and feel free to close, merge or change it.

@zugdev zugdev requested a review from rndquu as a code owner November 6, 2024 03:12
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Nov 6, 2024

@rndquu
Copy link
Member

rndquu commented Nov 6, 2024

@zugdev

Most of the contracts mentioned in this PR are deprecated and will never be used again. There's this list of our current relevant contract deployments.

You could either refactor current PR to mention contracts from https://github.com/ubiquity/ubiquity-dollar/wiki/24.-Smart-Contracts either create a new wiki page with the deprecated contracts (because it'd be useful for staking v2).

@zugdev
Copy link
Contributor Author

zugdev commented Nov 7, 2024

Would you rather:

  1. Have both useful and deprecated deployments tables in wiki

  2. Have useful deployments table in readme and deprecated in wiki

  3. Have useful table in readme and both in wiki too

@rndquu
Copy link
Member

rndquu commented Nov 7, 2024

Would you rather:

  1. Have both useful and deprecated deployments tables in wiki
  2. Have useful deployments table in readme and deprecated in wiki
  3. Have useful table in readme and both in wiki too

Useful deployments could be placed in the readme file, deprecated deployments could be placed in wiki for future references

@zugdev
Copy link
Contributor Author

zugdev commented Nov 7, 2024

If you check the wiki's sidebar, there is a reference to "Smart Contracts (legacy)".

image

That page is empty, and I think the order is wrong. I will change the sidebar and add a new page below the 24th for the deprecated contracts.


The new page is Deprecated Deployments. I've also updated the sidebar accordingly.

@rndquu rndquu merged commit ca74325 into ubiquity:development Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants