Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive Web App #90

Closed
0x4007 opened this issue Sep 19, 2024 · 27 comments · Fixed by #131
Closed

Progressive Web App #90

0x4007 opened this issue Sep 19, 2024 · 27 comments · Fixed by #131

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 19, 2024

At this conference, there were several instances where I had bad signal, and I generally like to pitch by showing this interface.

The problem is that it loads the issues after you load the page so it takes a moment and I'm staring at an empty screen essentially.

Turning this into a progressive Web app should allow us to instantly load the cached issues, even when off-line or disconnected

@inspikalu
Copy link

inspikalu commented Sep 21, 2024

Greetings is this task still open. Because it seems like some work has been done on it. Can i go ahead with the task?
@0x4007

@gentlementlegen
Copy link
Member

@inspikalu As long as there is no one assigned and the tasks is open, you can work on it.

@akshaydhayal
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Sep 23, 2024

! Please set your wallet address with the /wallet command first and try again.

Copy link
Contributor

ubiquity-os bot commented Sep 23, 2024

! No wallet address found

@akshaydhayal
Copy link

/wallet 0x74ab0142c5C1eB394Ceb9A5d57078C527535c398

Copy link
Contributor

ubiquity-os bot commented Sep 23, 2024

+ Successfully registered wallet address

@akshaydhayal
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Sep 23, 2024

Deadline Tue, Sep 24, 5:56 PM UTC
Beneficiary 0x74ab0142c5C1eB394Ceb9A5d57078C527535c398

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Sep 30, 2024

@akshaydhayal, this task has been idle for a while. Please provide an update.

Copy link
Contributor

ubiquity-os bot commented Oct 4, 2024

@akshaydhayal, this task has been idle for a while. Please provide an update.

@zugdev
Copy link
Contributor

zugdev commented Oct 9, 2024

I believe caching issues in indexedDB and adding an if to not syncTasks if offline would work after #114 will make the issues part of it work.

@zugdev
Copy link
Contributor

zugdev commented Oct 19, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Oct 19, 2024

! You have reached your max task limit. Please close out some tasks before assigning new ones.

1 similar comment
Copy link
Contributor

ubiquity-os bot commented Oct 19, 2024

! You have reached your max task limit. Please close out some tasks before assigning new ones.

@ubiquity-os ubiquity-os bot reopened this Oct 21, 2024
Copy link
Contributor

ubiquity-os bot commented Oct 21, 2024

! All linked pull requests must be closed to generate rewards.

Copy link
Contributor

ubiquity-os bot commented Oct 21, 2024

@zugdev the deadline is at Tue, Oct 22, 6:23 AM UTC

@0x4007 0x4007 closed this as completed Oct 21, 2024
Copy link
Contributor

ubiquity-os bot commented Oct 21, 2024

 [ 401.485 UUSD ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueTask1400
IssueComment11.485
ReviewComment90
Conversation Incentives
CommentFormattingRelevanceReward
I believe caching issues in indexedDB and adding an if to not sy…
1.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 27
  wordValue: 0.1
  result: 1.65
0.91.485
Resolves #90Currently working offline by caching issues. When …
15
content:
  content:
    p:
      score: 0
      elementCount: 8
    a:
      score: 5
      elementCount: 3
  result: 15
regex:
  wordCount: 62
  wordValue: 0
  result: 0
0.90
This already makes the entire app work offline. We need to add a…
2.98
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 24
  wordValue: 0.2
  result: 2.98
0.40
Refac on PWA based in [this document.](https://developer.mozilla…
6.05
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 7
  wordValue: 0.2
  result: 1.05
0.50
yeah that's why I switched to a draft. there are some google req…
2.55
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 20
  wordValue: 0.2
  result: 2.55
0.30
Working offline but look how weird it behaves hahah[weird.webm…
6.54
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 11
  wordValue: 0.2
  result: 1.54
0.20
@0x4007 test it out and please let me remove `console.log()&…
1.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 13
  wordValue: 0.2
  result: 1.77
0.50
Let's just skip auth if completely offline. We could cache user …
2.66
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 21
  wordValue: 0.2
  result: 2.66
0.70
This PR should handle both scenarios well, I am caching issues a…
6.4
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 59
  wordValue: 0.2
  result: 6.4
0.80
Already removed comments, pls go ahead
0.92
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 6
  wordValue: 0.2
  result: 0.92
0.60

 [ 0.159 UUSD ] 

@inspikalu
Contributions Overview
ViewContributionCountReward
IssueComment10.159
Conversation Incentives
CommentFormattingRelevanceReward
Greetings is this task still open. Because it seems like some wo…
1.54
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 25
  wordValue: 0.1
  result: 1.54
0.40.159

 [ 0.244 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment10.244
Conversation Incentives
CommentFormattingRelevanceReward
@inspikalu As long as there is no one assigned and the tasks is …
1.22
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 19
  wordValue: 0.1
  result: 1.22
0.20.244

 [ 21.703 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification111.25
ReviewComment410.453
Conversation Incentives
CommentFormattingRelevanceReward
At this conference, there were several instances where I had bad…
3.75
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 71
  wordValue: 0.1
  result: 3.75
111.25
QA works code looks fine
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
0.10.039
9ababa2![image](https://github.com/user-attachments/assets/ec39…
5.1
content:
  content:
    p:
      score: 0
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 1
  wordValue: 0.1
  result: 0.1
05
![image](https://github.com/user-attachments/assets/00f71720-ccb…
5.71
content:
  content:
    p:
      score: 0
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 10
  wordValue: 0.1
  result: 0.71
0.55.355
Let me know when you want to merge.
0.59
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 8
  wordValue: 0.1
  result: 0.59
0.10.059

@0x4007
Copy link
Member Author

0x4007 commented Oct 23, 2024

Hey @zugdev I noticed the double flicker/render on load after this. Would you mind pushing an adjustment for that?

I think you might be able to change the render function to compare what it wants to render, with what is already rendered. If its the same thing (as I suspect it will be based on how you implemented it) then skip calling the render function again.

@zugdev
Copy link
Contributor

zugdev commented Oct 23, 2024

Hey @zugdev I noticed the double flicker/render on load after this. Would you mind pushing an adjustment for that?

It happens when your cached issue list is not up to date with the official one. First it renders from cache and in paralel fetches from json. Eventually that promisse returns an issue list, and if cached is different from fetched it will cache and then re-render. I suppose I could bypass the animation for the second run.

@0x4007
Copy link
Member Author

0x4007 commented Oct 23, 2024

Hey @zugdev I noticed the double flicker/render on load after this. Would you mind pushing an adjustment for that?

It happens when your cached issue list is not up to date with the official one. First it renders from cache and in paralel fetches from json. Eventually that promisse returns an issue list, and if cached is different from fetched it will cache and then re-render. I suppose I could bypass the animation for the second run.

Maybe appending the difference could be ideal, particularly if it is below-the-fold.

@zugdev
Copy link
Contributor

zugdev commented Oct 25, 2024

Some UUSD payments are working and some are reverting. This one is reverting.

image

Need to investigate why though. @0x4007

@gentlementlegen
Copy link
Member

@zugdev When was it generated? We had an issue with permits that was resolved a few days ago, if you show me which one I can re-generate it.

@zugdev
Copy link
Contributor

zugdev commented Oct 25, 2024

Hey @gentlementlegen here are all four issues I had trouble claiming. One or two are WXDAI but feel free to generate one or multiple UUSD permits.

  1. Invalidation button no longer displays pay.ubq.fi#331

  2. Deep Links #118

  3. Progressive Web App #90

  4. Preview Deployer Bug pay.ubq.fi#298

Copy link
Contributor

ubiquity-os bot commented Oct 25, 2024

 [ 414.63 UUSD ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueTask1400
IssueComment414.63
ReviewComment90
Conversation Incentives
CommentFormattingRelevanceReward
I believe caching issues in indexedDB and adding an if to not sy…
1.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 27
  wordValue: 0.1
  result: 1.65
0.81.32
It happens when your cached issue list is not up to date with th…
3.2
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 59
  wordValue: 0.1
  result: 3.2
0.72.24
Some UUSD payments are working and some are reverting. This one …
6.22
content:
  content:
    p:
      score: 0
      elementCount: 3
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 19
  wordValue: 0.1
  result: 1.22
0.65.732
Hey @gentlementlegen here are all four issues I had trouble clai…
6.34
content:
  content:
    p:
      score: 0
      elementCount: 5
    ol:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 4
  result: 3
regex:
  wordCount: 62
  wordValue: 0.1
  result: 3.34
0.75.338
Resolves #90Currently working offline by caching issues. When …
15
content:
  content:
    p:
      score: 0
      elementCount: 8
    a:
      score: 5
      elementCount: 3
  result: 15
regex:
  wordCount: 62
  wordValue: 0
  result: 0
0.90
This already makes the entire app work offline. We need to add a…
2.98
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 24
  wordValue: 0.2
  result: 2.98
0.50
Refac on PWA based in [this document.](https://developer.mozilla…
6.05
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 7
  wordValue: 0.2
  result: 1.05
0.60
yeah that's why I switched to a draft. there are some google req…
2.55
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 20
  wordValue: 0.2
  result: 2.55
0.40
Working offline but look how weird it behaves hahah[weird.webm…
6.54
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 11
  wordValue: 0.2
  result: 1.54
0.30
@0x4007 test it out and please let me remove `console.log()&…
1.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 13
  wordValue: 0.2
  result: 1.77
0.70
Let's just skip auth if completely offline. We could cache user …
2.66
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 21
  wordValue: 0.2
  result: 2.66
0.60
This PR should handle both scenarios well, I am caching issues a…
6.4
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 59
  wordValue: 0.2
  result: 6.4
0.80
Already removed comments, pls go ahead
0.92
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 6
  wordValue: 0.2
  result: 0.92
0.50

 [ 0.159 UUSD ] 

@inspikalu
Contributions Overview
ViewContributionCountReward
IssueComment10.159
Conversation Incentives
CommentFormattingRelevanceReward
Greetings is this task still open. Because it seems like some wo…
1.54
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 25
  wordValue: 0.1
  result: 1.54
0.40.159

 [ 1.013 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment21.013
Conversation Incentives
CommentFormattingRelevanceReward
@inspikalu As long as there is no one assigned and the tasks is …
1.22
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 19
  wordValue: 0.1
  result: 1.22
0.40.488
@zugdev When was it generated? We had an issue with permits that…
1.75
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 29
  wordValue: 0.1
  result: 1.75
0.30.525

 [ 29.012 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification111.25
IssueComment26.832
ReviewComment410.93
Conversation Incentives
CommentFormattingRelevanceReward
At this conference, there were several instances where I had bad…
3.75
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 71
  wordValue: 0.1
  result: 3.75
111.25
Hey @zugdev I noticed the double flicker/render on load after th…
7.13
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 67
  wordValue: 0.2
  result: 7.13
0.85.704
Maybe appending the difference could be ideal, particularly if i…
1.88
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 14
  wordValue: 0.2
  result: 1.88
0.61.128
QA works code looks fine
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
0.60.234
9ababa2![image](https://github.com/user-attachments/assets/ec39…
5.1
content:
  content:
    p:
      score: 0
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 1
  wordValue: 0.1
  result: 0.1
0.15.01
![image](https://github.com/user-attachments/assets/00f71720-ccb…
5.71
content:
  content:
    p:
      score: 0
      elementCount: 1
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 10
  wordValue: 0.1
  result: 0.71
0.85.568
Let me know when you want to merge.
0.59
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 8
  wordValue: 0.1
  result: 0.59
0.20.118

@gentlementlegen
Copy link
Member

@zugdev You should now be able to claim, let me know if the issue persists.

@zugdev
Copy link
Contributor

zugdev commented Oct 25, 2024

Claimed all, looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants