feat: added pwa features #92
Conversation
|
@rndquu @gentlementlegen can you guys look into continuous deployments? Really inconvenient to QA without it |
I'll check it now |
@rndquu if you were able to identify the problem, and didn't have time to implement a solution - perhaps you can file an issue and one of us can jump on it |
|
I got it to load six issues fully but it does not work offline as per the spec
It seems like you're certainly on the right track though. |
There was a problem hiding this comment.
What do you mean by formatting exactly? If you are referring to the yarn format cmd, I did do that and it was the same code which I committed .
There was a problem hiding this comment.
Indentation is wrong in your diff. Not sure what to tell you but it looks like you're not using our prettier settings. There is a possibility this was committed without the correct formatting but highly unlikely because we use a template with the same formatter in all of our projects.
There was a problem hiding this comment.
The formatter is only producing these indentations. If I manually remove these indentation and run the formatter, they are produced again.
See the formatter did checked this file: 
There was a problem hiding this comment.
Indentations seems correct if you checkout the code, I added try catch blocks, maybe that's why it might be showing in code changes.
There was a problem hiding this comment.
@0x4007 , what to do for this change?
There was a problem hiding this comment.
I also don't see formatting issues in the fetch-issues-full.ts although the PR diff shows new indentations.
There was a problem hiding this comment.
Perhaps spaces were changed to tabs.
There was a problem hiding this comment.
The PR works fine. Could you resolve the code conflicts?
One more question:
When running on localhost the UI is opened fine without an internet connection while the latest development preview page doesn't work offline. What could be the issue?
|
I think redoing the pull would be easier because a lot of changes were made in the last two weeks. |
Resolves #90
This is related to issue #90 . The issues are able to load in local development without the internet.