Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some bottom padding to issues-container #145

Closed
wants to merge 1 commit into from

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Oct 30, 2024

Resolves #144

QA:
image

@zugdev zugdev requested a review from 0x4007 as a code owner October 30, 2024 03:38
@ubiquity-os-deployer
Copy link

@0x4007
Copy link
Member

0x4007 commented Oct 30, 2024

This doesn't fix. Consider the iOS specific viewport resizing due to the safari toolbar

@zugdev
Copy link
Contributor Author

zugdev commented Oct 30, 2024

You mean preview is being cut by footer, so we have 2 bugs, because the issue list was previously hidden under bottom toolbar too. Will add a fix for the preview.

This is what currently is solved:
image

@zugdev
Copy link
Contributor Author

zugdev commented Oct 30, 2024

This is very weird, when emulating mobile on desktop it works fine as in screenshot:

image

But it doesn't work in my mobile too. Not only Safari, Chrome and Firefox too. I can take a closer look later, but could create an issue on it too.

@zugdev zugdev closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add some more bottom padding to issues-container
2 participants