Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing broken cache in text filter #72

Closed
wants to merge 5 commits into from
Closed

Fixing broken cache in text filter #72

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fabe4de
feat: fetch from network if there is an error in cache
Sadaf-A Jul 12, 2024
7509cec
feat: fetch from network if there is a cache error
Sadaf-A Jul 12, 2024
b3c6bef
fix: formatting code and using try and catch block for relevant parts…
Sadaf-A Jul 12, 2024
6ba7c85
fix: formatting fix and using try catch block for relevant part only
Sadaf-A Jul 12, 2024
fa8fa98
fix: code fix
Sadaf-A Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions src/home/fetch-github/fetch-and-display-previews.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,27 @@ export async function fetchAndDisplayPreviewsFromCache(sorting?: Sorting, option
return fetchAndDisplayPreviewsFromNetwork(sorting, options);
}

// makes sure tasks have a timestamp to know how old the cache is, or refresh if older than 15 minutes
if (!_cachedTasks || !_cachedTasks.timestamp || _cachedTasks.timestamp + 60 * 1000 * 15 <= Date.now()) {
_cachedTasks = {
timestamp: Date.now(),
tasks: [],
loggedIn: _accessToken !== null,
};
}

const cachedTasks = _cachedTasks.tasks as TaskMaybeFull[];
taskManager.syncTasks(cachedTasks);
try {
// makes sure tasks have a timestamp to know how old the cache is, or refresh if older than 15 minutes
if (!_cachedTasks || !_cachedTasks.timestamp || _cachedTasks.timestamp + 60 * 1000 * 15 <= Date.now()) {
_cachedTasks = {
timestamp: Date.now(),
tasks: [],
loggedIn: _accessToken !== null,
};
}
const cachedTasks = _cachedTasks.tasks as TaskMaybeFull[];
taskManager.syncTasks(cachedTasks);

if (!cachedTasks.length) {
// load from network if there are no cached issues
if (!cachedTasks.length) {
// load from network if there are no cached issues
return fetchAndDisplayPreviewsFromNetwork(sorting, options);
} else {
displayGitHubIssues(sorting, options);
return fetchAvatars();
}
} catch (cacheError) {
return fetchAndDisplayPreviewsFromNetwork(sorting, options);
} else {
displayGitHubIssues(sorting, options);
return fetchAvatars();
}
}

Expand Down