Target cleanup #119
Merged
Target cleanup #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
No functional change. Add comment on this new helper too. Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
Add central helper for handling both read and write, which shares lots of code. No functional change. Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
This variable is useless, so remove it. Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
Add two target data flag: UBLK_IO_TGT_BUF UBLK_IO_TGT_IO The former means this uring OP is for buffer operation, and the latter means this uring OP is for normal IO operation, and we should store io result for normal IO operation. And IO command is supposed to be complete when all operations are done, so use local variable to count how many uring OPs are submitted & completed. Also add ublksrv_tgt_io_done() as default handler for ->tgt_io_done() Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
It should be possible for running out of sqe, especially with ublk zero copy feature, so add one helper for dealing with this situation. Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
So far USER_COPY doesn't need to pass buffer address, but still need to allocate buffer. And ZERO_COPY needn't to pass and allocate buffer. Reviewed-by: Ronnie Sahlberg <[email protected]> Signed-off-by: Ming Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #116, let merge the prepare part first.