chore(ci): add image pull with retry #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still won't catch all issues, and it doesn't even try to pre-pull akmods or config image layers ... but we have other efforts in flight to address those concerns by moving to a dnf/yum repo instead. |
castrojo
approved these changes
Feb 22, 2024
|
The failure on this currently is a kernel version incompatibility between a kmod and image kernel. Shouldn't block merging of this. |
noelmiller
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another in a series of PRs which have been proposed for #502 .
My thought is to identify areas in build_image which have spurious failures and fix them if reasonable within our scripting, or otherwise address issues, like this one.
The idea here is we fix the spurious failures pulling our (very large) base images, by pulling them to the build runner before using the buildah action.