-
Notifications
You must be signed in to change notification settings - Fork 7
ubports-qa upgrades only the packages related to the PR/MR repo #30
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few remarks, but I also would prefer if this were implemented in python (I'm also fine if the whole script gets rewritten in bash, but this hybrid is not very nice IMHO) :-)
branch=$1 | ||
pkgs=$(pkgcheck "${branch}") | ||
apt-get update | ||
apt-get install $pkgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be remove
, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no actually, we're not really removing packages, we're downgrading packages. originally we were running apt full-upgrade here too
pkginstall will not and should not install something that isn't installed already
i have updated de logs to reflect this
i don't mind reimplementing it in python fwiw, this was just the easiest way to get something working, as i don't know as much python actually, after submitting this PR i attempted to reimplement pkgremove in python but appearently python's os.check_output quotes the list of packages breaking apt |
appearently you can upgrade a specific package by apt installing it
this assumes the package name is the same as the repository name, we may need a more robust way to read the correct package name