Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation.md #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update documentation.md #51

wants to merge 2 commits into from

Conversation

uarif
Copy link

@uarif uarif commented Oct 5, 2023

References..

@reshnashrestha
Copy link
Contributor

@uarif We have already added the resources. It is just that it hasn't been merged yet. Thank you!

@laserlab
Copy link
Contributor

laserlab commented Oct 6, 2023

@reshnashrestha Please add the reference to the Pull request where you made the changes

@reshnashrestha
Copy link
Contributor

@laserlab I did addition of resources on my own documentation file before @uarif told this.

@laserlab
Copy link
Contributor

laserlab commented Oct 6, 2023

I understand, but please reference the pull request where these changes were made here in this PR so @uarif can see if these are the same changes he suggested

@laserlab
Copy link
Contributor

laserlab commented Oct 6, 2023

And then again @uarif point of a PR is to actually add information and nit just commenting on missing information …

@uarif
Copy link
Author

uarif commented Oct 6, 2023

Yes, Will keep that in mind. Thank you for correcting me, prof. @laserlab

@laserlab
Copy link
Contributor

laserlab commented Oct 6, 2023

@uarif How about adding some references here in this PR so it becomes a real one?

Btw.: The PR @reshnashrestha is talking about is #50

@AhmedCode99 AhmedCode99 closed this Oct 6, 2023
@reshnashrestha
Copy link
Contributor

Yes I am talking about #50

Thank you @laserlab and @uarif
And sorry forgot to add reference before.

@laserlab laserlab reopened this Oct 6, 2023
@laserlab
Copy link
Contributor

laserlab commented Oct 6, 2023

Why does that get closed?

@reshnashrestha
Copy link
Contributor

I don't know, I didn't close it.

Copy link
Author

@uarif uarif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to write inside now, And I guess making a new pull request won't make sense, but some useful references I can put are below,
[1] https://docs.python.org/3/library/math.html#math.radians
[2] https://farside.ph.utexas.edu/teaching/336k/Newton/node29.html
[3] https://docs.python.org/3/tutorial/controlflow.html#lambda-expressions
And more... @laserlab @reshnashrestha

References added..
@uarif
Copy link
Author

uarif commented Oct 6, 2023

I am unable to write inside now, And I guess making a new pull request won't make sense, but some useful references I can put are below, [1] https://docs.python.org/3/library/math.html#math.radians [2] https://farside.ph.utexas.edu/teaching/336k/Newton/node29.html [3] https://docs.python.org/3/tutorial/controlflow.html#lambda-expressions And more... @laserlab @reshnashrestha

Actually, I did add some references to my original pull.. They might be able to see them now, @reshnashrestha @laserlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants