-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methane Data Collection #36
Conversation
…ame sites used in the co2 data collection task
Maybe having a LICENSE/NOTES/README would make it better? |
Yeah ill review it. |
I believe a NOTES txt is required that contains the license and citation for the data other than that It looks good. |
@avgagliardo The easiest and most convenient would be to just use the notes file already existing in the mount Lua folder since it is all the same data source. So I would suggest to @kylemasc917 to switch to approve this PR and then @avgagliardo makes a new PR with moving the NOTES file in the root folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good Approved.
You guys are right, I completely forgot about the README/LICENSE.MD file. I'll take care of that after classes today. |
DO it in a separate PR though so this can get merged asap @SchrodingersStruggle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please merge so I can use the data for testing
Merged it to keep work flowing, @avgagliardo make a separate pull request to add necessary files whenever you get the chance. |
Sounds good, thank you for the merge everybody. I'll get the license up in a new PR in a few mins. |
Methane Data Collection
Linting
There is no code included, though the code I used does lint and can be included.
Contents
This PR contains:
Labels and Milestones
Labels and Milestone have been properly set.
Reviewer
Open to all reviewers, maybe @kylemasc917 since he had a parallel task or someone that is directly downstream would be the most useful in the event they'd like to request changes.
It doesn't take much to reshape the data, so if there's something that I missed or that I can do to make it more convenient just let me know in the review.
Thanks!