-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original frequency plot and removed periodic frequencies plot #37
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I can review this as requested. |
Yes please, as I need this for my task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Averager and erase do not seem to be functions supported in the current requirements we have for the repository. You can either request the packages needed for these functions to be added to the requirements file, or change the functions into something which can be used by anyone.
I would reference specific lines, but I'm not entirely sure how to do that in a Jupyter file. |
@SchrodingersStruggle Thank you for the review! those were functions defined in preperation.py in PR #30 but not merged into main by the time I created this PR. I will fix it today should be no later than 5PM. |
Actually cancel that I will fix it right now |
Code has been fixed now, ready to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required filename is data_analysis.ipynb
Thank you, fixed now |
Once one of the reviewers gives an approval ill merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@SchrodingersStruggle awaiting your approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, especially now that dependancies are sorted.
You just need to resolve the last merge conflict and it should be ok to merge |
@kylemasc917 merge conflict resolved |
As soon as this PR gets merged I will add my code with the original data_analysis.ipynb that was added with PR #36 |
@kylemasc917 check PR #44 |
ok feel free to close this |
For this assignment all pull requests going forward should contain the following (please delete the placeholder text and add your own description)
Title
Linting
Contents
Labels and Milestones
Reviewer
Any further questions on formatting pull requests can be asked in the issues tab or on discord.
This document can be changed at any time.