Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning image (cube grid top) #42

Merged
merged 9 commits into from
Nov 19, 2024
Merged

Cleaning image (cube grid top) #42

merged 9 commits into from
Nov 19, 2024

Conversation

Cosmos491
Copy link
Contributor

  1. This PR builds on the code written by haiderabbas007, p-pxmpo and jkblc.
  2. Task Group 3 members were supposed to work on a single data analysis Jupyter notebook called data_analysis.ipynb
  3. I have used the data from the image folder that contains the file "cube_grid_top_data.pkl".

Sugessted reviewer: @haiderabbas007 @jkblc

I combined the code already written, and was able to generate the required images from the pickle files using functions from preparation.py
@Cosmos491 Cosmos491 added the python python related label Nov 18, 2024
@Cosmos491 Cosmos491 added this to the Cleaned-up Image milestone Nov 18, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@haiderabbas007
Copy link
Contributor

Only the cleaned-up image is needed, the original is not needed. Secondly, can you choose the same scale for both axes? The output image should be squarish.

added the code to clean the file named "cube_grid_top_data.pkl"
it says invalid file format
Upon the suggestions of the reviewer, I will make the shape squarish and get rid of this file
I added the code to clean the image that is in the  image folder with the name "cube_grid_top_data.pkl
@Cosmos491
Copy link
Contributor Author

Thank you for the suggestions @haiderabbas007 . I have now made the desired changes.

@kylemasc917
Copy link
Contributor

@haiderabbas007 If these are good please approve so they can be merged.

Copy link
Contributor

@haiderabbas007 haiderabbas007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Ved

@kylemasc917 kylemasc917 merged commit 352dc16 into ubsuny:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants