Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my code (cleaned up image - cube side) to data_analysis.ipynb #45

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

haiderabbas007
Copy link
Contributor

@haiderabbas007 haiderabbas007 commented Nov 19, 2024

Refer to PR #40 which was my actual PR. Due to logistical issues, I am creating this new PR.

This code lints 10/10.

Suggested Reviewer: @p-pxmpo @Cosmos491 @kylemasc917

@haiderabbas007 haiderabbas007 added documentation Improvements or additions to documentation Algorithm/subalgorithm in relation to the fulfillment of a full functioning code labels Nov 19, 2024
@haiderabbas007 haiderabbas007 added this to the Cleaned-up Image milestone Nov 19, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@haiderabbas007 haiderabbas007 changed the title Added my code to data_analysis.ipynb Added my code (cleaned up image - cube side) to data_analysis.ipynb Nov 19, 2024
Copy link
Contributor

@p-pxmpo p-pxmpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the merging conflict and its good to merge

@haiderabbas007 haiderabbas007 merged commit 6d6d3b3 into ubsuny:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algorithm/subalgorithm in relation to the fulfillment of a full functioning code documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants