CP1-24-midterm #26
Open
CP1-24-midterm #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two points based on latitude and longitude inputs. test_midterm_mods acts as a unit test for the modules using pytest. unit_converter can convert feet and yards to meters. unix_time can take in a time and return unix time. Implementing file reading in the necessary modules is still a work in progress
moved this file to the main file
moved this file to the main folder
moved this file to the main file
moving this file to the main file
need to commit to make sure files are in sync
added more tests to test_midterm_mods, and added the motion_direction module to determine the direction of motion in an elevator
having an issue wher the jupyter file imports old versions of python files instead of the latest versions.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I'm aware that there's a pytest error coming up. In my codespace, /workspaces/CP1-24-midterm/abruns123/ data/test/test_name works for the file path reference. It does not once I do the pull request on here. I've heard that others just use the main file name which in my case is /abruns123/data/test/test_name but that isn't working either hence the closing and reopening of the pull request trying to figure this out. I just ended up going with the /abruns123/data/test/test_name because that's what I've heard is the right way to write out the file path name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.