-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add system tray functionality #824
feat(app): add system tray functionality #824
Conversation
3b5f9fd
to
ce0bbcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey again 👋
Added three change requests/helps
I noticed two things also:
- on linux the dialog pops up and if you do so the app is successfully put into tray and still running and reacting to gnome shell play/pause, however clicking the icon does not return the app to visible mode
- on macos it didnt work at all :( the app just closed, but we could also just add this only for linux and I can try to make it work for macos and windows after your PR (no ETA), that would mean instead of checking for !isMobile you check for Platform.isLinux
I checked other apps using the tray_manager library, and none of them can open a window by clicking on the icon in Linux. Some programs have conditions in their code to show/hide the window if the system is Windows, otherwise, they display a popup menu. As for the behavior on macOS, I cannot verify it because I don't have the corresponding environment. |
it doesnt need to be the icon but if the icon with a minimized app would show a menu and one of the menu items is "show window"->click->shows window this would be enough (like in discord/telegram etc) |
Clicking the icon to show/hide the window seems to be possible in Linux for qt programs, but not for gtk3 programs. |
ce0bbcd
to
ed44a5c
Compare
2293332
to
20d9eb4
Compare
- Update pubspec.yaml with tray_manager dependency. - Initialize system tray in app.dart and handle menu item clicks.
ed44a5c
to
1c84971
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep it for linux for now so we can test it with the next snap edge release. I got fixed ready which will be pushed then this will be merged and we can test it on linux in the snap edge
Ref #793